zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move RTCOutboundRTPStreamStats.roundTripTime to inbound, don't collect.

Browse Source 
The value is being moved:
https://github.com/w3c/webrtc-stats/pull/167

Stop collecting this value. Our previous value was incorrect, our RTT
value was a smoothed value based on STUN pings but the spec says it
should be based on RTCP timestamps in RTCP Receiver Report (RR) on
inbound streams with isRemote=true (not supported).

Updated some bug references.

BUG=webrtc:7065, webrtc:7066

Review-Url: https://codereview.webrtc.org/2722633005
Cr-Commit-Position: refs/heads/master@{#16931}
This commit is contained in:
hbos
2017-03-01 01:02:45 -08:00
committed by Commit bot
parent deaf6fb071
commit a7a9be159d
5 changed files with 24 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
webrtc/api/stats/rtcstats_objects.h
View File

@ -327,8 +327,8 @@ class RTCRTPStreamStats : public RTCStats {
};
// https://w3c.github.io/webrtc-stats/#inboundrtpstats-dict*
// Tracking bug crbug.com/657855
// TODO(hbos): Support the remote case |is_remote = true|. crbug.com/657855
// TODO(hbos): Support the remote case |is_remote = true|.
// https://bugs.webrtc.org/7065
class RTCInboundRTPStreamStats final : public RTCRTPStreamStats {
public:
WEBRTC_RTCSTATS_DECL();
@ -341,36 +341,38 @@ class RTCInboundRTPStreamStats final : public RTCRTPStreamStats {
RTCStatsMember<uint32_t> packets_received;
RTCStatsMember<uint64_t> bytes_received;
RTCStatsMember<uint32_t> packets_lost;
// TODO(hbos): Not collected in the "video" case by |RTCStatsCollector|.
// crbug.com/657855
// TODO(hbos): Collect and populate this value for both "audio" and "video",
// currently not collected for "video". https://bugs.webrtc.org/7065
RTCStatsMember<double> jitter;
RTCStatsMember<double> fraction_lost;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
// TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7065
RTCStatsMember<double> round_trip_time;
// TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7065
RTCStatsMember<uint32_t> packets_discarded;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
// TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7065
RTCStatsMember<uint32_t> packets_repaired;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
// TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7065
RTCStatsMember<uint32_t> burst_packets_lost;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
// TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7065
RTCStatsMember<uint32_t> burst_packets_discarded;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
// TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7065
RTCStatsMember<uint32_t> burst_loss_count;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
// TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7065
RTCStatsMember<uint32_t> burst_discard_count;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
// TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7065
RTCStatsMember<double> burst_loss_rate;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
// TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7065
RTCStatsMember<double> burst_discard_rate;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
// TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7065
RTCStatsMember<double> gap_loss_rate;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657855
// TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7065
RTCStatsMember<double> gap_discard_rate;
RTCStatsMember<uint32_t> frames_decoded;
};
// https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict*
// Tracking bug crbug.com/657856
// TODO(hbos): Support the remote case |is_remote = true|. crbug.com/657856
// TODO(hbos): Support the remote case |is_remote = true|.
// https://bugs.webrtc.org/7066
class RTCOutboundRTPStreamStats final : public RTCRTPStreamStats {
public:
WEBRTC_RTCSTATS_DECL();
@ -382,9 +384,8 @@ class RTCOutboundRTPStreamStats final : public RTCRTPStreamStats {
RTCStatsMember<uint32_t> packets_sent;
RTCStatsMember<uint64_t> bytes_sent;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657856
// TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7066
RTCStatsMember<double> target_bitrate;
RTCStatsMember<double> round_trip_time;
RTCStatsMember<uint32_t> frames_encoded;
};