zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move RTCOutboundRTPStreamStats.roundTripTime to inbound, don't collect.

Browse Source 
The value is being moved:
https://github.com/w3c/webrtc-stats/pull/167

Stop collecting this value. Our previous value was incorrect, our RTT
value was a smoothed value based on STUN pings but the spec says it
should be based on RTCP timestamps in RTCP Receiver Report (RR) on
inbound streams with isRemote=true (not supported).

Updated some bug references.

BUG=webrtc:7065, webrtc:7066

Review-Url: https://codereview.webrtc.org/2722633005
Cr-Commit-Position: refs/heads/master@{#16931}
This commit is contained in:
hbos
2017-03-01 01:02:45 -08:00
committed by Commit bot
parent deaf6fb071
commit a7a9be159d
5 changed files with 24 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/stats/rtcstats_objects.cc
View File

@ -513,6 +513,7 @@ WEBRTC_RTCSTATS_IMPL(
&packets_lost,
&jitter,
&fraction_lost,
&round_trip_time,
&packets_discarded,
&packets_repaired,
&burst_packets_lost,
@ -538,6 +539,7 @@ RTCInboundRTPStreamStats::RTCInboundRTPStreamStats(
packets_lost("packetsLost"),
jitter("jitter"),
fraction_lost("fractionLost"),
round_trip_time("roundTripTime"),
packets_discarded("packetsDiscarded"),
packets_repaired("packetsRepaired"),
burst_packets_lost("burstPacketsLost"),
@ -559,6 +561,7 @@ RTCInboundRTPStreamStats::RTCInboundRTPStreamStats(
packets_lost(other.packets_lost),
jitter(other.jitter),
fraction_lost(other.fraction_lost),
round_trip_time(other.round_trip_time),
packets_discarded(other.packets_discarded),
packets_repaired(other.packets_repaired),
burst_packets_lost(other.burst_packets_lost),
@ -580,7 +583,6 @@ WEBRTC_RTCSTATS_IMPL(
&packets_sent,
&bytes_sent,
&target_bitrate,
&round_trip_time,
&frames_encoded);
RTCOutboundRTPStreamStats::RTCOutboundRTPStreamStats(
@ -594,7 +596,6 @@ RTCOutboundRTPStreamStats::RTCOutboundRTPStreamStats(
packets_sent("packetsSent"),
bytes_sent("bytesSent"),
target_bitrate("targetBitrate"),
round_trip_time("roundTripTime"),
frames_encoded("framesEncoded") {
}
@ -604,7 +605,6 @@ RTCOutboundRTPStreamStats::RTCOutboundRTPStreamStats(
packets_sent(other.packets_sent),
bytes_sent(other.bytes_sent),
target_bitrate(other.target_bitrate),
round_trip_time(other.round_trip_time),
frames_encoded(other.frames_encoded) {
}