zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"""

Browse Source 
This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613.

Reason for revert: 
The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660

Original change's description:
> Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""
> 
> This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16.
> 
> Reason for revert: 
> 
> Breaks Chrome FYI:
> 
> /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
>   -> returned 1
> ERROR at //build/split_static_library.gni:12:5: Dependency not allowed.
>     static_library(target_name) {
>     ^----------------------------
> The item //content/renderer:renderer
> can not depend on //third_party/webrtc/media:rtc_internal_video_codecs
> because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [
>   //third_party/webrtc/*
>   //third_party/webrtc_overrides/*
> ]
> 
>  https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout
> 
> Original change's description:
> > GN rtc_* templates: Set default visibility to webrtc_root + "/*"
> > 
> > This means that by default, targets are visible to everything under
> > the WebRTC root, but not visible to anything else.
> > 
> > API targets are manually tagged with visibility "*", so that targets
> > outside the WebRTC tree can see them.
> > 
> > BUG=webrtc:8254
> > 
> > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509
> > Reviewed-on: https://webrtc-review.googlesource.com/24140
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#21548}
> 
> TBR=mbonadei@webrtc.org,kwiberg@webrtc.org
> 
> Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:8254
> Reviewed-on: https://webrtc-review.googlesource.com/38760
> Reviewed-by: Per Kjellander <perkj@webrtc.org>
> Commit-Queue: Per Kjellander <perkj@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21555}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org

Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8254
Reviewed-on: https://webrtc-review.googlesource.com/38860
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21558}
This commit is contained in:
Per Kjellander
2018-01-10 15:54:53 +00:00
committed by Commit Bot
parent 0e6d2f5118
commit a7f2d84ad1
42 changed files with 167 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
modules/audio_coding/BUILD.gn
View File

@ -40,7 +40,7 @@ audio_coding_deps = audio_codec_deps + [
]
rtc_static_library("audio_format_conversion") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"codecs/audio_format_conversion.cc",
"codecs/audio_format_conversion.h",
@ -57,7 +57,7 @@ rtc_static_library("audio_format_conversion") {
}
rtc_static_library("rent_a_codec") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"acm2/acm_codec_database.cc",
"acm2/acm_codec_database.h",
@ -297,7 +297,7 @@ config("ilbc_config") {
}
rtc_static_library("ilbc") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"codecs/ilbc/audio_decoder_ilbc.cc",
"codecs/ilbc/audio_decoder_ilbc.h",
@ -823,7 +823,7 @@ rtc_source_set("pcm16b_c") {
}
rtc_static_library("webrtc_opus") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"codecs/opus/audio_decoder_opus.cc",
"codecs/opus/audio_decoder_opus.h",
@ -884,7 +884,7 @@ rtc_source_set("webrtc_opus_c") {
if (rtc_enable_protobuf) {
proto_library("ana_debug_dump_proto") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"audio_network_adaptor/debug_dump.proto",
]
@ -902,7 +902,7 @@ if (rtc_enable_protobuf) {
}
rtc_static_library("audio_network_adaptor_config") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"audio_network_adaptor/audio_network_adaptor_config.cc",
"audio_network_adaptor/include/audio_network_adaptor_config.h",
@ -913,7 +913,7 @@ rtc_static_library("audio_network_adaptor_config") {
}
rtc_static_library("audio_network_adaptor") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"audio_network_adaptor/audio_network_adaptor_impl.cc",
"audio_network_adaptor/audio_network_adaptor_impl.h",
@ -984,7 +984,7 @@ rtc_source_set("neteq_decoder_enum") {
}
rtc_static_library("neteq") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"neteq/accelerate.cc",
"neteq/accelerate.h",
@ -1082,7 +1082,7 @@ rtc_static_library("neteq") {
# that ultimately are built and run as a part of the Chromium ecosystem, which
# does not set the rtc_include_tests flag.
rtc_source_set("neteq_tools_minimal") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"neteq/tools/audio_sink.cc",
"neteq/tools/audio_sink.h",
@ -1119,7 +1119,7 @@ rtc_source_set("neteq_tools_minimal") {
}
rtc_source_set("neteq_test_tools") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
testonly = true
sources = [
"neteq/tools/audio_checksum.h",
@ -1178,7 +1178,7 @@ config("neteq_tools_config") {
}
rtc_source_set("neteq_tools") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"neteq/tools/fake_decode_from_file.cc",
"neteq/tools/fake_decode_from_file.h",
@ -1214,7 +1214,7 @@ rtc_source_set("neteq_tools") {
}
rtc_source_set("neteq_input_audio_tools") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"neteq/tools/input_audio_file.cc",
"neteq/tools/input_audio_file.h",
@ -1275,7 +1275,7 @@ if (rtc_include_tests) {
}
group("audio_coding_tests") {
visibility += [ "*" ]
visibility += webrtc_default_visibility
testonly = true
public_deps = [
":acm_receive_test",
@ -1310,7 +1310,7 @@ if (rtc_include_tests) {
rtc_source_set("audio_coding_modules_tests") {
testonly = true
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"test/ACMTest.h",
@ -1374,7 +1374,7 @@ if (rtc_include_tests) {
rtc_source_set("audio_coding_perf_tests") {
testonly = true
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"codecs/opus/opus_complexity_unittest.cc",
@ -2053,7 +2053,7 @@ if (rtc_include_tests) {
rtc_source_set("audio_coding_unittests") {
testonly = true
visibility += [ "*" ]
visibility += webrtc_default_visibility
sources = [
"acm2/acm_receiver_unittest.cc",