Fix circular dependencies between optional, array_view, and rtc_base.

This splits things out of rtc_base and makes dependencies explicit.

Bug: webrtc:6828
Change-Id: Ib813c7bd9e4de7ab015acb917bc09ee7204ba7bd
Reviewed-on: https://webrtc-review.googlesource.com/31940
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21245}
This commit is contained in:
Patrik Höglund
2017-12-13 13:39:48 +01:00
committed by Commit Bot
parent 10a8e7a9b5
commit a9e0924fa7
55 changed files with 334 additions and 145 deletions

View File

@ -229,8 +229,10 @@ rtc_static_library("audio_processing") {
"../../api:array_view",
"../../api:optional",
"../../audio/utility:audio_frame_operations",
"../../rtc_base:checks",
"../../rtc_base:gtest_prod",
"../../rtc_base:protobuf_utils",
"../../rtc_base:sanitizer",
"../../system_wrappers:cpu_features_api",
"../../system_wrappers:metrics_api",
"../audio_coding:isac",
@ -340,6 +342,7 @@ rtc_source_set("audio_processing_c") {
deps = [
"../..:webrtc_common",
"../../common_audio",
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
"../../system_wrappers:cpu_features_api",
]
@ -402,7 +405,9 @@ rtc_source_set("aec_core") {
":audio_processing_statistics",
"../..:webrtc_common",
"../../common_audio:common_audio",
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:sanitizer",
"../../system_wrappers:cpu_features_api",
"../../system_wrappers:metrics_api",
]
@ -580,6 +585,7 @@ if (rtc_include_tests) {
"../../api:array_view",
"../../api:optional",
"../../common_audio:common_audio",
"../../rtc_base:checks",
"../../rtc_base:gtest_prod",
"../../rtc_base:protobuf_utils",
"../../rtc_base:rtc_base",
@ -733,6 +739,7 @@ if (rtc_include_tests) {
"../../api:array_view",
"../../common_audio:common_audio",
"../../modules:module_api",
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
]
}
@ -758,6 +765,7 @@ if (rtc_include_tests) {
":audioproc_test_utils",
"../../api:optional",
"../../common_audio:common_audio",
"../../rtc_base:checks",
"../../rtc_base:protobuf_utils",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:rtc_task_queue",
@ -792,6 +800,7 @@ if (rtc_include_tests) {
"../../api:array_view",
"../../api:optional",
"../../common_audio",
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
"../../system_wrappers",
"../../test:test_support",
@ -844,6 +853,7 @@ if (rtc_include_tests) {
":audio_processing",
":audioproc_test_utils",
"../../common_audio:common_audio",
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
"../../system_wrappers:metrics_default",
]

View File

@ -74,6 +74,7 @@ if (rtc_enable_protobuf) {
deps = [
"../../../modules:module_api",
"../../../rtc_base:checks",
"../../../rtc_base:protobuf_utils",
"../../../rtc_base:rtc_base_approved",
"../../../rtc_base:rtc_task_queue",

View File

@ -47,6 +47,7 @@ rtc_static_library("lib") {
"../../../..:webrtc_common",
"../../../../api:array_view",
"../../../../common_audio",
"../../../../rtc_base:checks",
"../../../../rtc_base:rtc_base_approved",
]
visibility = [ ":*" ] # Only targets in this file can depend on this.

View File

@ -117,6 +117,7 @@ rtc_executable("fake_polqa") {
output_name = "py_quality_assessment/quality_assessment/fake_polqa"
deps = [
"../../../..:webrtc_common",
"../../../../rtc_base:checks",
"../../../../rtc_base:rtc_base_approved",
]
}