zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removes all const Clock*.

Browse Source 
This prepares for making the Clock interface fully mutable.

Calls to the time functions in Clock can have side effects in some
circumstances. It's also questionable if it's a good idea to allow
repeated calls to a const method return different values without
any changed to the class instance.

Bug: webrtc:9883
Change-Id: I96fb9230705f7c80a4c0702132fd9dc73899fc5e
Reviewed-on: https://webrtc-review.googlesource.com/c/120347
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26467}
This commit is contained in:
Sebastian Jansson
2019-01-30 11:28:59 +01:00
committed by Commit Bot
parent 15df2ef2c0
commit aa01f27667
32 changed files with 55 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/congestion_controller/include/receive_side_congestion_controller.h
View File

@ -30,8 +30,7 @@ class RemoteBitrateObserver;
class ReceiveSideCongestionController : public CallStatsObserver,
public Module {
public:
ReceiveSideCongestionController(const Clock* clock,
PacketRouter* packet_router);
ReceiveSideCongestionController(Clock* clock, PacketRouter* packet_router);
~ReceiveSideCongestionController() override {}
@ -57,8 +56,7 @@ class ReceiveSideCongestionController : public CallStatsObserver,
private:
class WrappingBitrateEstimator : public RemoteBitrateEstimator {
public:
WrappingBitrateEstimator(RemoteBitrateObserver* observer,
const Clock* clock);
WrappingBitrateEstimator(RemoteBitrateObserver* observer, Clock* clock);
~WrappingBitrateEstimator() override;
@ -84,7 +82,7 @@ class ReceiveSideCongestionController : public CallStatsObserver,
RTC_EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
void PickEstimator() RTC_EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
RemoteBitrateObserver* observer_;
const Clock* const clock_;
Clock* const clock_;
rtc::CriticalSection crit_sect_;
std::unique_ptr<RemoteBitrateEstimator> rbe_;
bool using_absolute_send_time_;

4
modules/congestion_controller/include/send_side_congestion_controller.h
View File

@ -51,7 +51,7 @@ class DEPRECATED_SendSideCongestionController
public:
using Observer = NetworkChangedObserver;
DEPRECATED_SendSideCongestionController(
const Clock* clock,
Clock* clock,
Observer* observer,
RtcEventLog* event_log,
PacedSender* pacer,
@ -140,7 +140,7 @@ class DEPRECATED_SendSideCongestionController
RTC_EXCLUSIVE_LOCKS_REQUIRED(&probe_lock_);
const FieldTrialBasedConfig field_trial_config_;
const WebRtcKeyValueConfig* const key_value_config_;
const Clock* const clock_;
Clock* const clock_;
rtc::CriticalSection observer_lock_;
Observer* observer_ RTC_GUARDED_BY(observer_lock_);
RtcEventLog* const event_log_;