From aa023e255308ac2532ce23c3c33d0fb78af2acd5 Mon Sep 17 00:00:00 2001 From: Jakob Ivarsson Date: Wed, 27 Mar 2019 10:17:31 +0100 Subject: [PATCH] Add test-only group id. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: chromium:943076 Change-Id: Ife855fe59fe5e358bc94e4bb0da704ee2647dbd9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129900 Reviewed-by: Henrik Boström Commit-Queue: Henrik Boström Cr-Commit-Position: refs/heads/master@{#27356} --- api/stats/rtc_stats.h | 2 ++ stats/rtc_stats_unittest.cc | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/api/stats/rtc_stats.h b/api/stats/rtc_stats.h index ed3765c3c2..bb23490ce4 100644 --- a/api/stats/rtc_stats.h +++ b/api/stats/rtc_stats.h @@ -184,6 +184,8 @@ class RTC_EXPORT RTCStats { // determine if a stats member should be exposed or not. Multiple non-standard // stats members can share the same group ID so that they are exposed together. enum class NonStandardGroupId { + // Group ID used for testing purposes only. + kGroupIdForTesting, // I2E: // https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hE2B1iItPDk kRtcAudioJitterBufferMaxPackets, diff --git a/stats/rtc_stats_unittest.cc b/stats/rtc_stats_unittest.cc index 1a948ba32b..b159977858 100644 --- a/stats/rtc_stats_unittest.cc +++ b/stats/rtc_stats_unittest.cc @@ -340,7 +340,7 @@ TEST(RTCStatsTest, IsStandardized) { } TEST(RTCStatsTest, NonStandardGroupId) { - auto group_id = NonStandardGroupId::kRtcAudioJitterBufferMaxPackets; + auto group_id = NonStandardGroupId::kGroupIdForTesting; RTCNonStandardStatsMember with_group_id("stat", {group_id}); std::vector expected_ids({group_id}); EXPECT_EQ(expected_ids, with_group_id.group_ids());