zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tune vp9 screenshare bitrate and framerate of spatial layers

Browse Source 
VP9 screenshare is not used currently, and with these values according
to local testing with screenshare_loopback, we get performance not worse
than current vp8 settings for similar uplink and downlink values.

Bug: webrtc:10257
Change-Id: Icabac04fbd3d616412bbae59291a1fc026d0a504
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126226
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27023}
This commit is contained in:
Ilya Nikolaevskiy
2019-03-07 16:27:03 +01:00
committed by Commit Bot
parent 39d3a7de02
commit aaf3cb3adb
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/video_coding/codecs/vp9/svc_config.cc
View File

@ -23,10 +23,10 @@ namespace {
const size_t kMinVp9SvcBitrateKbps = 30; const size_t kMinVp9SvcBitrateKbps = 30;
const size_t kMaxNumLayersForScreenSharing = 3; const size_t kMaxNumLayersForScreenSharing = 3;
const float kMaxScreenSharingLayerFramerateFps[] = {5.0, 5.0, 30.0}; const float kMaxScreenSharingLayerFramerateFps[] = {5.0, 10.0, 30.0};
const size_t kMinScreenSharingLayerBitrateKbps[] = {30, 150, 500}; const size_t kMinScreenSharingLayerBitrateKbps[] = {30, 200, 500};
const size_t kTargetScreenSharingLayerBitrateKbps[] = {150, 350, 1000}; const size_t kTargetScreenSharingLayerBitrateKbps[] = {150, 350, 950};
const size_t kMaxScreenSharingLayerBitrateKbps[] = {200, 500, 1000}; const size_t kMaxScreenSharingLayerBitrateKbps[] = {250, 500, 950};
} // namespace } // namespace

2
modules/video_coding/codecs/vp9/svc_config_unittest.cc
View File

@ -54,7 +54,7 @@ TEST(SvcConfig, ScreenSharing) {
const SpatialLayer& layer = spatial_layers[i]; const SpatialLayer& layer = spatial_layers[i];
EXPECT_EQ(layer.width, 1920); EXPECT_EQ(layer.width, 1920);
EXPECT_EQ(layer.height, 1080); EXPECT_EQ(layer.height, 1080);
EXPECT_EQ(layer.maxFramerate, (i < 2) ? 5 : 30); EXPECT_EQ(layer.maxFramerate, (i < 1) ? 5 : (i < 2 ? 10 : 30));
EXPECT_EQ(layer.numberOfTemporalLayers, 1); EXPECT_EQ(layer.numberOfTemporalLayers, 1);
EXPECT_LE(layer.minBitrate, layer.maxBitrate); EXPECT_LE(layer.minBitrate, layer.maxBitrate);
EXPECT_LE(layer.minBitrate, layer.targetBitrate); EXPECT_LE(layer.minBitrate, layer.targetBitrate);