From ab587dc9a4b67c8d64be7e11c99fffdf51f0a1f2 Mon Sep 17 00:00:00 2001 From: mbonadei Date: Fri, 12 May 2017 04:13:31 -0700 Subject: [PATCH] Moving check_package_boundaries to the presubmit checks directory Since we now have a directory for this kind of checks, let's move this to that location. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2870393006 Cr-Commit-Position: refs/heads/master@{#18122} --- PRESUBMIT.py | 3 ++- .../{ => presubmit_checks_lib}/check_package_boundaries.py | 0 .../check_package_boundaries_test.py | 0 .../testdata/all_build_files/BUILD.gn | 0 .../testdata/all_build_files/expected.pyl | 0 .../testdata/all_build_files/subpackage1/BUILD.gn | 0 .../all_build_files/subpackage1/subsubpackage1/BUILD.gn | 0 .../testdata/all_build_files/subpackage2/BUILD.gn | 0 .../all_build_files/subpackage2/subsubpackage2/BUILD.gn | 0 .../{ => presubmit_checks_lib}/testdata/common_prefix/BUILD.gn | 0 .../testdata/common_prefix/call/BUILD.gn | 0 .../testdata/common_prefix/expected.pyl | 0 .../testdata/multiple_errors_multiple_targets/BUILD.gn | 0 .../testdata/multiple_errors_multiple_targets/expected.pyl | 0 .../multiple_errors_multiple_targets/subpackage1/BUILD.gn | 0 .../multiple_errors_multiple_targets/subpackage2/BUILD.gn | 0 .../testdata/multiple_errors_single_target/BUILD.gn | 0 .../testdata/multiple_errors_single_target/expected.pyl | 0 .../testdata/multiple_errors_single_target/subpackage/BUILD.gn | 0 .../{ => presubmit_checks_lib}/testdata/no_errors/BUILD.gn | 0 .../{ => presubmit_checks_lib}/testdata/no_errors/expected.pyl | 0 21 files changed, 2 insertions(+), 1 deletion(-) rename tools_webrtc/{ => presubmit_checks_lib}/check_package_boundaries.py (100%) rename tools_webrtc/{ => presubmit_checks_lib}/check_package_boundaries_test.py (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/all_build_files/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/all_build_files/expected.pyl (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/all_build_files/subpackage1/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/all_build_files/subpackage1/subsubpackage1/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/all_build_files/subpackage2/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/all_build_files/subpackage2/subsubpackage2/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/common_prefix/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/common_prefix/call/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/common_prefix/expected.pyl (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/multiple_errors_multiple_targets/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/multiple_errors_multiple_targets/expected.pyl (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/multiple_errors_multiple_targets/subpackage1/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/multiple_errors_multiple_targets/subpackage2/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/multiple_errors_single_target/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/multiple_errors_single_target/expected.pyl (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/multiple_errors_single_target/subpackage/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/no_errors/BUILD.gn (100%) rename tools_webrtc/{ => presubmit_checks_lib}/testdata/no_errors/expected.pyl (100%) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index e2d0dd50d0..fe1acfe7ee 100755 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -332,7 +332,8 @@ def _CheckNoMixingCAndCCSources(input_api, gn_files, output_api): def _CheckNoPackageBoundaryViolations(input_api, gn_files, output_api): cwd = input_api.PresubmitLocalPath() - script_path = os.path.join('tools_webrtc', 'check_package_boundaries.py') + script_path = os.path.join('tools_webrtc', 'presubmit_checks_lib', + 'check_package_boundaries.py') webrtc_path = os.path.join('webrtc') command = [sys.executable, script_path, webrtc_path] command += [gn_file.LocalPath() for gn_file in gn_files] diff --git a/tools_webrtc/check_package_boundaries.py b/tools_webrtc/presubmit_checks_lib/check_package_boundaries.py similarity index 100% rename from tools_webrtc/check_package_boundaries.py rename to tools_webrtc/presubmit_checks_lib/check_package_boundaries.py diff --git a/tools_webrtc/check_package_boundaries_test.py b/tools_webrtc/presubmit_checks_lib/check_package_boundaries_test.py similarity index 100% rename from tools_webrtc/check_package_boundaries_test.py rename to tools_webrtc/presubmit_checks_lib/check_package_boundaries_test.py diff --git a/tools_webrtc/testdata/all_build_files/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/all_build_files/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/all_build_files/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/all_build_files/BUILD.gn diff --git a/tools_webrtc/testdata/all_build_files/expected.pyl b/tools_webrtc/presubmit_checks_lib/testdata/all_build_files/expected.pyl similarity index 100% rename from tools_webrtc/testdata/all_build_files/expected.pyl rename to tools_webrtc/presubmit_checks_lib/testdata/all_build_files/expected.pyl diff --git a/tools_webrtc/testdata/all_build_files/subpackage1/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/all_build_files/subpackage1/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/all_build_files/subpackage1/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/all_build_files/subpackage1/BUILD.gn diff --git a/tools_webrtc/testdata/all_build_files/subpackage1/subsubpackage1/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/all_build_files/subpackage1/subsubpackage1/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/all_build_files/subpackage1/subsubpackage1/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/all_build_files/subpackage1/subsubpackage1/BUILD.gn diff --git a/tools_webrtc/testdata/all_build_files/subpackage2/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/all_build_files/subpackage2/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/all_build_files/subpackage2/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/all_build_files/subpackage2/BUILD.gn diff --git a/tools_webrtc/testdata/all_build_files/subpackage2/subsubpackage2/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/all_build_files/subpackage2/subsubpackage2/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/all_build_files/subpackage2/subsubpackage2/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/all_build_files/subpackage2/subsubpackage2/BUILD.gn diff --git a/tools_webrtc/testdata/common_prefix/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/common_prefix/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/common_prefix/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/common_prefix/BUILD.gn diff --git a/tools_webrtc/testdata/common_prefix/call/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/common_prefix/call/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/common_prefix/call/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/common_prefix/call/BUILD.gn diff --git a/tools_webrtc/testdata/common_prefix/expected.pyl b/tools_webrtc/presubmit_checks_lib/testdata/common_prefix/expected.pyl similarity index 100% rename from tools_webrtc/testdata/common_prefix/expected.pyl rename to tools_webrtc/presubmit_checks_lib/testdata/common_prefix/expected.pyl diff --git a/tools_webrtc/testdata/multiple_errors_multiple_targets/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_multiple_targets/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/multiple_errors_multiple_targets/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_multiple_targets/BUILD.gn diff --git a/tools_webrtc/testdata/multiple_errors_multiple_targets/expected.pyl b/tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_multiple_targets/expected.pyl similarity index 100% rename from tools_webrtc/testdata/multiple_errors_multiple_targets/expected.pyl rename to tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_multiple_targets/expected.pyl diff --git a/tools_webrtc/testdata/multiple_errors_multiple_targets/subpackage1/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_multiple_targets/subpackage1/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/multiple_errors_multiple_targets/subpackage1/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_multiple_targets/subpackage1/BUILD.gn diff --git a/tools_webrtc/testdata/multiple_errors_multiple_targets/subpackage2/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_multiple_targets/subpackage2/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/multiple_errors_multiple_targets/subpackage2/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_multiple_targets/subpackage2/BUILD.gn diff --git a/tools_webrtc/testdata/multiple_errors_single_target/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_single_target/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/multiple_errors_single_target/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_single_target/BUILD.gn diff --git a/tools_webrtc/testdata/multiple_errors_single_target/expected.pyl b/tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_single_target/expected.pyl similarity index 100% rename from tools_webrtc/testdata/multiple_errors_single_target/expected.pyl rename to tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_single_target/expected.pyl diff --git a/tools_webrtc/testdata/multiple_errors_single_target/subpackage/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_single_target/subpackage/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/multiple_errors_single_target/subpackage/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_single_target/subpackage/BUILD.gn diff --git a/tools_webrtc/testdata/no_errors/BUILD.gn b/tools_webrtc/presubmit_checks_lib/testdata/no_errors/BUILD.gn similarity index 100% rename from tools_webrtc/testdata/no_errors/BUILD.gn rename to tools_webrtc/presubmit_checks_lib/testdata/no_errors/BUILD.gn diff --git a/tools_webrtc/testdata/no_errors/expected.pyl b/tools_webrtc/presubmit_checks_lib/testdata/no_errors/expected.pyl similarity index 100% rename from tools_webrtc/testdata/no_errors/expected.pyl rename to tools_webrtc/presubmit_checks_lib/testdata/no_errors/expected.pyl