zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete RtpRtcp methods SetKeyFrameRequestMethod and RequestKeyFrame

Browse Source 
These are replaced with the methods SendPictureLossIndication and
SendFullIntraRequest, added in cl
https://webrtc-review.googlesource.com/c/src/+/140043.

Also delete the corresponding state variable
RtpRtcpImpl::key_frame_req_method_, the enum KeyFrameRequestMethod,
and the nearby unused enum RtpRtcpPacketType.

Bug: None
Change-Id: I1ac2e4ce6dbe20d1d1cbb3d5b2256ea55b341a57
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141403
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28221}
This commit is contained in:
Niels Möller
2019-06-11 10:38:01 +02:00
committed by Commit Bot
parent 1a5fc9035b
commit ab6fc1154f
5 changed files with 0 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
modules/rtp_rtcp/include/rtp_rtcp.h
View File

@ -423,17 +423,6 @@ class RtpRtcp : public Module, public RtcpFeedbackSenderInterface {
// using FIR, https://tools.ietf.org/html/rfc5104#section-4.3.1.2
void SendFullIntraRequest() { SendRTCP(kRtcpFir); }
// Set method for requestion a new key frame.
// Returns -1 on failure else 0.
RTC_DEPRECATED
virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0;
// Sends a request for a keyframe.
// Returns -1 on failure else 0.
// Use above SendPictureLossIndication and SendFullIntraRequest instead.
RTC_DEPRECATED
virtual int32_t RequestKeyFrame() = 0;
// Sends a LossNotification RTCP message.
// Returns -1 on failure else 0.
virtual int32_t SendLossNotification(uint16_t last_decoded_seq_num,