zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Checking whether ACM uses codec internal or WebRTC DTX.

Browse Source 
It was not clear how one could know if ACM is using DTX from WebRTC or codec internal DTX.

This CL makes better use of IsInternalDTXReplacedWithWebRtc() which was designed for G.729 to export such information.

Before
IsInternalDTXReplacedWithWebRtc() gives true only if codec == G729 and G729's internal DTX is replaced with WebRTC DTX.

Now
IsInternalDTXReplacedWithWebRtc() gives true also when codec does not have internal DTX, i.e., must use WebRTC DTX, which is much more logical.

BUG=
R=henrik.lundin@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/35459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7870 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
minyue@webrtc.org
2014-12-11 08:53:21 +00:00
parent 55d42c32a4
commit abe3f1879c
3 changed files with 29 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
webrtc/modules/audio_coding/main/interface/audio_coding_module.h
View File

@ -507,8 +507,7 @@ class AudioCodingModule: public Module {
///////////////////////////////////////////////////////////////////////////
// int32_t ReplaceInternalDTXWithWebRtc()
// Used to replace codec internal DTX scheme with WebRtc. This is only
// supported for G729, where this call replaces AnnexB with WebRtc DTX.
// Used to replace codec internal DTX scheme with WebRtc.
//
// Input:
// -use_webrtc_dtx : if false (default) the codec built-in DTX/VAD
@ -524,8 +523,8 @@ class AudioCodingModule: public Module {
///////////////////////////////////////////////////////////////////////////
// int32_t IsInternalDTXReplacedWithWebRtc()
// Get status if the codec internal DTX (when such exists) is replaced with
// WebRtc DTX. This is only supported for G729.
// Get status if the codec internal DTX is replaced with WebRtc DTX.
// This should always be true if codec does not have an internal DTX.
//
// Output:
// -uses_webrtc_dtx : is set to true if the codec internal DTX is