zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix style violations in common_types.h and config.h

Browse Source 
Mostly, it's about moving constructors and descructors to the .cc
files, so that they won't be inlined everywhere.

The reason this CL is so big is that a lot of code was using
common_types.h without declaring a dependency on webrtc_common, which
broke the build once common_types.h started to depend on
common_types.cc.

BUG=163
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/26089004

Cr-Commit-Position: refs/heads/master@{#8516}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8516 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
kwiberg@webrtc.org
2015-02-26 13:59:22 +00:00
parent 891d48393e
commit ac2d27d9ae
53 changed files with 139 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
webrtc/modules/audio_coding/BUILD.gn
View File

@ -72,6 +72,7 @@ source_set("audio_coding") {
":neteq",
":pcm16b",
":red",
"../..:webrtc_common",
"../../common_audio",
"../../system_wrappers",
]
@ -89,6 +90,7 @@ source_set("audio_decoder_interface") {
]
configs += [ "../..:common_config" ]
public_configs = [ "../..:common_inherited_config" ]
deps = [ "../..:webrtc_common" ]
}
source_set("audio_encoder_interface") {
@ -98,6 +100,7 @@ source_set("audio_encoder_interface") {
]
configs += [ "../..:common_config" ]
public_configs = [ "../..:common_inherited_config" ]
deps = [ "../..:webrtc_common" ]
}
config("cng_config") {
@ -439,12 +442,6 @@ source_set("isac") {
"codecs/isac/main/source/transform.c",
]
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
if (is_linux) {
libs = [ "m" ]
}
@ -518,12 +515,6 @@ source_set("isacfix") {
"codecs/isac/fix/source/transform_tables.c",
]
if (is_clang) {
# Suppress warnings from Chrome's Clang plugins.
# See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
if (!is_win) {
defines = [ "WEBRTC_LINUX" ]
}
@ -786,6 +777,7 @@ source_set("neteq") {
":isac",
":isacfix",
":pcm16b",
"../..:webrtc_common",
"../../common_audio",
"../../system_wrappers",
rtc_opus_dir,