zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add mb.py to pylint check of the root PRESUBMIT.py.

Browse Source 
This now possible because of https://webrtc-review.googlesource.com/c/src/+/256972

Bug: webrtc:13605
Change-Id: Ie5c058c5ff459dde05c90f757a1df8bd53f35ccc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257281
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36390}
This commit is contained in:
Jeremy Leconte
2022-03-31 11:55:01 +02:00
committed by WebRTC LUCI CQ
parent 7b26037693
commit ac5cf78801
4 changed files with 56 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tools_webrtc/mb/mb.py
View File

@ -24,7 +24,7 @@ sys.path.insert(0, _SRC_DIR)
from tools.mb import mb
def _get_executable(target, platform):
def _GetExecutable(target, platform):
executable_prefix = '.\\' if platform == 'win32' else './'
executable_suffix = '.exe' if platform == 'win32' else ''
return executable_prefix + target + executable_suffix
@ -37,7 +37,7 @@ def main(args):
class WebRTCMetaBuildWrapper(mb.MetaBuildWrapper):
def __init__(self):
super(WebRTCMetaBuildWrapper, self).__init__()
super().__init__()
# Make sure default_config and default_isolate_map are attributes of the
# parent class before changing their values.
# pylint: disable=access-member-before-definition
@ -93,7 +93,7 @@ class WebRTCMetaBuildWrapper(mb.MetaBuildWrapper):
elif test_type == 'raw':
cmdline += [vpython_exe, '../../tools_webrtc/flags_compatibility.py']
extra_files.append('../../tools_webrtc/flags_compatibility.py')
cmdline.append(_get_executable(target, self.platform))
cmdline.append(_GetExecutable(target, self.platform))
else:
if isolate_map[target].get('use_webcam', False):
cmdline += [
@ -144,7 +144,7 @@ class WebRTCMetaBuildWrapper(mb.MetaBuildWrapper):
# Retry would hide most sanitizers detections.
cmdline.append('--retry_failed=3')
cmdline.append(_get_executable(target, self.platform))
cmdline.append(_GetExecutable(target, self.platform))
cmdline.extend([
'--asan=%d' % asan,