zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable the clang style plugin in rtc_base/

Browse Source 
Enabled the plugin and cleaned up all issues it found.

Bug: webrtc:163
Change-Id: Id63f0deb7b335690157ab157c35177b7836688da
Reviewed-on: https://webrtc-review.googlesource.com/14660
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20401}
This commit is contained in:
Steve Anton
2017-10-23 14:56:38 -07:00
committed by Commit Bot
parent c5ee987d26
commit af551a1956
35 changed files with 497 additions and 353 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
rtc_base/thread_unittest.cc
View File

@ -44,7 +44,6 @@ class TestGenerator {
struct TestMessage : public MessageData {
explicit TestMessage(int v) : value(v) {}
virtual ~TestMessage() {}
int value;
};
@ -60,9 +59,7 @@ class SocketClient : public TestGenerator, public sigslot::has_slots<> {
socket_->SignalReadPacket.connect(this, &SocketClient::OnPacket);
}
~SocketClient() {
delete socket_;
}
~SocketClient() override { delete socket_; }
SocketAddress address() const { return socket_->GetLocalAddress(); }
@ -90,11 +87,9 @@ class MessageClient : public MessageHandler, public TestGenerator {
: socket_(socket) {
}
virtual ~MessageClient() {
delete socket_;
}
~MessageClient() override { delete socket_; }
virtual void OnMessage(Message *pmsg) {
void OnMessage(Message* pmsg) override {
TestMessage* msg = static_cast<TestMessage*>(pmsg->pdata);
int result = Next(msg->value);
EXPECT_GE(socket_->Send(&result, sizeof(result)), 0);
@ -109,7 +104,7 @@ class CustomThread : public rtc::Thread {
public:
CustomThread()
: Thread(std::unique_ptr<SocketServer>(new rtc::NullSocketServer())) {}
virtual ~CustomThread() { Stop(); }
~CustomThread() override { Stop(); }
bool Start() { return false; }
bool WrapCurrent() {
@ -129,12 +124,12 @@ class SignalWhenDestroyedThread : public Thread {
: Thread(std::unique_ptr<SocketServer>(new NullSocketServer())),
event_(event) {}
virtual ~SignalWhenDestroyedThread() {
~SignalWhenDestroyedThread() override {
Stop();
event_->Set();
}
virtual void Run() {
void Run() override {
// Do nothing.
}