zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prefix bool variable with "should".

Browse Source 
This is to address a comment in a CL landed earlier.

BUG=

Review-Url: https://codereview.webrtc.org/2137223002
Cr-Commit-Position: refs/heads/master@{#13435}
This commit is contained in:
honghaiz
2016-07-11 15:09:26 -07:00
committed by Commit bot
parent b4d31085b4
commit af6b6e021f
3 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm
View File

@ -33,8 +33,9 @@
_iceBackupCandidatePairPingInterval;
@synthesize keyType = _keyType;
@synthesize iceCandidatePoolSize = _iceCandidatePoolSize;
@synthesize pruneTurnPorts = _pruneTurnPorts;
@synthesize presumeWritableWhenFullyRelayed = _presumeWritableWhenFullyRelayed;
@synthesize shouldPruneTurnPorts = _shouldPruneTurnPorts;
@synthesize shouldPresumeWritableWhenFullyRelayed =
_shouldPresumeWritableWhenFullyRelayed;
- (instancetype)init {
if (self = [super init]) {
@ -61,8 +62,8 @@
config.ice_backup_candidate_pair_ping_interval;
_keyType = RTCEncryptionKeyTypeECDSA;
_iceCandidatePoolSize = config.ice_candidate_pool_size;
_pruneTurnPorts = config.prune_turn_ports;
_presumeWritableWhenFullyRelayed =
_shouldPruneTurnPorts = config.prune_turn_ports;
_shouldPresumeWritableWhenFullyRelayed =
config.presume_writable_when_fully_relayed;
}
return self;
@ -83,8 +84,8 @@
_iceConnectionReceivingTimeout,
_iceBackupCandidatePairPingInterval,
_iceCandidatePoolSize,
_pruneTurnPorts,
_presumeWritableWhenFullyRelayed];
_shouldPruneTurnPorts,
_shouldPresumeWritableWhenFullyRelayed];
}
#pragma mark - Private
@ -128,9 +129,9 @@
nativeConfig->certificates.push_back(certificate);
}
nativeConfig->ice_candidate_pool_size = _iceCandidatePoolSize;
nativeConfig->prune_turn_ports = _pruneTurnPorts;
nativeConfig->prune_turn_ports = _shouldPruneTurnPorts ? true : false;
nativeConfig->presume_writable_when_fully_relayed =
_presumeWritableWhenFullyRelayed;
_shouldPresumeWritableWhenFullyRelayed ? true : false;
return nativeConfig.release();
}