zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete internal getter methods from RtpRtcpInterface

Browse Source 
Methods deleted: StorePackets, RtcpXrRrtrStatus. They are now private
methods on the two implementations.

Bug: None
Change-Id: If68e8f1e8ba233302e24e0cdb6bf7c1b0c9f330f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194322
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32670}
This commit is contained in:
Niels Möller
2020-11-20 12:21:21 +01:00
committed by Commit Bot
parent a28ae40ce2
commit af6ea0c3ab
6 changed files with 12 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/rtp_rtcp/source/rtp_rtcp_impl.h
View File

@ -238,8 +238,6 @@ class ModuleRtpRtcpImpl : public RtpRtcp, public RTCPReceiver::ModuleRtpRtcp {
// requests.
void SetStorePacketsStatus(bool enable, uint16_t number_to_store) override;
bool StorePackets() const override;
void SendCombinedRtcpPacket(
std::vector<std::unique_ptr<rtcp::RtcpPacket>> rtcp_packets) override;
@ -252,8 +250,6 @@ class ModuleRtpRtcpImpl : public RtpRtcp, public RTCPReceiver::ModuleRtpRtcp {
// (XR) Receiver reference time report.
void SetRtcpXrRrtrStatus(bool enable) override;
bool RtcpXrRrtrStatus() const override;
// Video part.
int32_t SendLossNotification(uint16_t last_decoded_seq_num,
uint16_t last_received_seq_num,
@ -326,6 +322,12 @@ class ModuleRtpRtcpImpl : public RtpRtcp, public RTCPReceiver::ModuleRtpRtcp {
bool TimeToSendFullNackList(int64_t now) const;
// Returns true if the module is configured to store packets.
bool StorePackets() const;
// Returns current Receiver Reference Time Report (RTTR) status.
bool RtcpXrRrtrStatus() const;
std::unique_ptr<RtpSenderContext> rtp_sender_;
RTCPSender rtcp_sender_;