zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Remove all reference to carbon api (patchset #2 id:20001 of https://codereview.webrtc.org/2299633002/ )

Browse Source 
Reason for revert:
Breaks chromium build

Original issue's description:
> Remove all reference to carbon api
>
> BUG=webrtc:6282
>
> Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964
> Cr-Commit-Position: refs/heads/master@{#14080}

TBR=magjed@webrtc.org,mflodman@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6282

Review-Url: https://codereview.webrtc.org/2316563002
Cr-Commit-Position: refs/heads/master@{#14081}
This commit is contained in:
kthelgason
2016-09-06 00:43:58 -07:00
committed by Commit bot
parent dbd8b6bec4
commit b096aa7fd3
21 changed files with 830 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
webrtc/base/macutils_unittest.cc
View File

@ -16,3 +16,22 @@ TEST(MacUtilsTest, GetOsVersionName) {
LOG(LS_INFO) << "GetOsVersionName " << ver;
EXPECT_NE(rtc::kMacOSUnknown, ver);
}
TEST(MacUtilsTest, RunAppleScriptCompileError) {
std::string script("set value to to 5");
EXPECT_FALSE(rtc::RunAppleScript(script));
}
TEST(MacUtilsTest, RunAppleScriptRuntimeError) {
std::string script("set value to 5 / 0");
EXPECT_FALSE(rtc::RunAppleScript(script));
}
#ifdef CARBON_DEPRECATED
TEST(MacUtilsTest, DISABLED_RunAppleScriptSuccess) {
#else
TEST(MacUtilsTest, RunAppleScriptSuccess) {
#endif
std::string script("set value to 5");
EXPECT_TRUE(rtc::RunAppleScript(script));
}