zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed unused RTCP methods SendFeedbackPacket and SendNetworkStateEstimate

Browse Source 
Bug: webrtc:10742
Change-Id: I179089a7b5ffcfcd93a56c836338872f600599af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157161
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29498}
This commit is contained in:
Per Kjellander
2019-10-16 10:41:32 +02:00
committed by Commit Bot
parent 2f4354e903
commit b11c4111f3
9 changed files with 1 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
modules/rtp_rtcp/include/rtp_rtcp.h
View File

@ -200,7 +200,7 @@ class RtpRtcp : public Module, public RtcpFeedbackSenderInterface {
virtual RtpState GetRtxState() const = 0;
// Returns SSRC.
uint32_t SSRC() const override = 0;
virtual uint32_t SSRC() const = 0;
// Sets the value for sending in the RID (and Repaired) RTP header extension.
// RIDs are used to identify an RTP stream if SSRCs are not negotiated.
@ -415,9 +415,6 @@ class RtpRtcp : public Module, public RtcpFeedbackSenderInterface {
// construction, remove this setter.
virtual void SetReportBlockDataObserver(
ReportBlockDataObserver* observer) = 0;
// BWE feedback packets.
bool SendFeedbackPacket(const rtcp::TransportFeedback& packet) override = 0;
virtual void SetVideoBitrateAllocation(
const VideoBitrateAllocation& bitrate) = 0;

4
modules/rtp_rtcp/include/rtp_rtcp_defines.h
View File

@ -314,10 +314,6 @@ class TransportFeedbackObserver {
class RtcpFeedbackSenderInterface {
public:
virtual ~RtcpFeedbackSenderInterface() = default;
virtual uint32_t SSRC() const = 0;
virtual bool SendFeedbackPacket(const rtcp::TransportFeedback& feedback) = 0;
virtual bool SendNetworkStateEstimatePacket(
const rtcp::RemoteEstimate& packet) = 0;
virtual void SendCombinedRtcpPacket(
std::vector<std::unique_ptr<rtcp::RtcpPacket>> rtcp_packets) = 0;
virtual void SetRemb(int64_t bitrate_bps, std::vector<uint32_t> ssrcs) = 0;