zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed unused RTCP methods SendFeedbackPacket and SendNetworkStateEstimate

Browse Source 
Bug: webrtc:10742
Change-Id: I179089a7b5ffcfcd93a56c836338872f600599af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157161
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29498}
This commit is contained in:
Per Kjellander
2019-10-16 10:41:32 +02:00
committed by Commit Bot
parent 2f4354e903
commit b11c4111f3
9 changed files with 1 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
modules/rtp_rtcp/source/rtcp_sender.cc
View File

@ -992,46 +992,6 @@ absl::optional<VideoBitrateAllocation> RTCPSender::CheckAndUpdateLayerStructure(
return updated_bitrate;
}
bool RTCPSender::SendFeedbackPacket(const rtcp::TransportFeedback& packet) {
size_t max_packet_size;
{
rtc::CritScope lock(&critical_section_rtcp_sender_);
if (method_ == RtcpMode::kOff)
return false;
max_packet_size = max_packet_size_;
}
RTC_DCHECK_LE(max_packet_size, IP_PACKET_SIZE);
bool send_failure = false;
auto callback = [&](rtc::ArrayView<const uint8_t> packet) {
if (transport_->SendRtcp(packet.data(), packet.size())) {
if (event_log_)
event_log_->Log(std::make_unique<RtcEventRtcpPacketOutgoing>(packet));
} else {
send_failure = true;
}
};
return packet.Build(max_packet_size, callback) && !send_failure;
}
bool RTCPSender::SendNetworkStateEstimatePacket(
const rtcp::RemoteEstimate& packet) {
size_t max_packet_size;
{
rtc::CritScope lock(&critical_section_rtcp_sender_);
if (method_ == RtcpMode::kOff)
return false;
max_packet_size = max_packet_size_;
}
RTC_DCHECK_LE(max_packet_size, IP_PACKET_SIZE);
bool send_success = false;
auto callback = [&](rtc::ArrayView<const uint8_t> packet) {
send_success = transport_->SendRtcp(packet.data(), packet.size());
};
return packet.Build(max_packet_size, callback) && send_success;
}
void RTCPSender::SendCombinedRtcpPacket(
std::vector<std::unique_ptr<rtcp::RtcpPacket>> rtcp_packets) {
size_t max_packet_size;