zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Create rtc::AtomicInt POD struct.

Browse Source 
Prevents accidental non-atomic reads, increments and stores since
"volatile int" doesn't enforce atomic usage.

BUG=
R=kwiberg@webrtc.org, tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1420043008

Cr-Commit-Position: refs/heads/master@{#10657}
This commit is contained in:
pbos
2015-11-16 11:03:04 -08:00
committed by Commit bot
parent 3528a27b1b
commit b27f590ece
12 changed files with 191 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/system_wrappers/source/trace_impl.cc
View File

@ -33,7 +33,7 @@ namespace webrtc {
const int Trace::kBoilerplateLength = 71;
const int Trace::kTimestampPosition = 13;
const int Trace::kTimestampLength = 12;
volatile int Trace::level_filter_ = kTraceDefault;
rtc::AtomicInt Trace::level_filter_(kTraceDefault);
// Construct On First Use idiom. Avoids "static initialization order fiasco".
TraceImpl* TraceImpl::StaticInstance(CountOperation count_operation,
@ -547,12 +547,12 @@ int32_t Trace::TraceFile(char file_name[FileWrapper::kMaxFileNameSize]) {
// static
void Trace::set_level_filter(int filter) {
rtc::AtomicOps::ReleaseStore(&level_filter_, filter);
rtc::AtomicInt::ReleaseStore(&level_filter_, filter);
}
// static
int Trace::level_filter() {
return rtc::AtomicOps::AcquireLoad(&level_filter_);
return rtc::AtomicInt::AcquireLoad(&level_filter_);
}
// static