zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename "OnReceivedFrame" to "OnAssembledFrame"

Browse Source 
The new name fits better.

Bug: None
Change-Id: I1f201ff07915ed6c18efeefb7380e2b286742bb9
Reviewed-on: https://webrtc-review.googlesource.com/c/123800
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26814}
This commit is contained in:
Elad Alon
2019-02-22 11:19:50 +01:00
committed by Commit Bot
parent d7329ca570
commit b4643ad7ba
7 changed files with 26 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
modules/video_coding/packet_buffer.h
View File

@ -32,11 +32,11 @@ namespace video_coding {
class RtpFrameObject;
// A received frame is a frame which has received all its packets.
class OnReceivedFrameCallback {
// A frame is assembled when all of its packets have been received.
class OnAssembledFrameCallback {
public:
virtual ~OnReceivedFrameCallback() {}
virtual void OnReceivedFrame(std::unique_ptr<RtpFrameObject> frame) = 0;
virtual ~OnAssembledFrameCallback() {}
virtual void OnAssembledFrame(std::unique_ptr<RtpFrameObject> frame) = 0;
};
class PacketBuffer {
@ -45,7 +45,7 @@ class PacketBuffer {
Clock* clock,
size_t start_buffer_size,
size_t max_buffer_size,
OnReceivedFrameCallback* frame_callback);
OnAssembledFrameCallback* frame_callback);
virtual ~PacketBuffer();
@ -72,7 +72,7 @@ class PacketBuffer {
PacketBuffer(Clock* clock,
size_t start_buffer_size,
size_t max_buffer_size,
OnReceivedFrameCallback* frame_callback);
OnAssembledFrameCallback* frame_callback);
private:
friend RtpFrameObject;
@ -155,8 +155,9 @@ class PacketBuffer {
// and information needed to determine the continuity between packets.
std::vector<ContinuityInfo> sequence_buffer_ RTC_GUARDED_BY(crit_);
// Called when a received frame is found.
OnReceivedFrameCallback* const received_frame_callback_;
// Called when all packets in a frame are received, allowing the frame
// to be assembled.
OnAssembledFrameCallback* const assembled_frame_callback_;
// Timestamp (not RTP timestamp) of the last received packet/keyframe packet.
absl::optional<int64_t> last_received_packet_ms_ RTC_GUARDED_BY(crit_);