zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable WebRTC-BindUsingInterfaceName by default

Browse Source 
But keep option to disable it.
The fix has been tested using A/B experiment with Duo
with positive results.

Bug: webrtc:10707
Change-Id: Iaac72430bc52026ab5db9dd042c5fdc3832fdce5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217380
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33941}
This commit is contained in:
Jonas Oreland
2021-05-04 09:09:24 +02:00
committed by WebRTC LUCI CQ
parent 256d631e2a
commit b5274ef8b9
4 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
rtc_base/network.cc
View File

@ -487,7 +487,7 @@ BasicNetworkManager::BasicNetworkManager(
allow_mac_based_ipv6_( allow_mac_based_ipv6_(
webrtc::field_trial::IsEnabled("WebRTC-AllowMACBasedIPv6")), webrtc::field_trial::IsEnabled("WebRTC-AllowMACBasedIPv6")),
bind_using_ifname_( bind_using_ifname_(
webrtc::field_trial::IsEnabled("WebRTC-BindUsingInterfaceName")) {} !webrtc::field_trial::IsDisabled("WebRTC-BindUsingInterfaceName")) {}
BasicNetworkManager::~BasicNetworkManager() {} BasicNetworkManager::~BasicNetworkManager() {}

3
rtc_base/network_unittest.cc
View File

@ -1307,9 +1307,6 @@ TEST_F(NetworkTest, WebRTC_AllowMACBasedIPv6Address) {
#if defined(WEBRTC_POSIX) #if defined(WEBRTC_POSIX)
TEST_F(NetworkTest, WebRTC_BindUsingInterfaceName) { TEST_F(NetworkTest, WebRTC_BindUsingInterfaceName) {
webrtc::test::ScopedFieldTrials field_trials(
"WebRTC-BindUsingInterfaceName/Enabled/");
char if_name1[20] = "wlan0"; char if_name1[20] = "wlan0";
char if_name2[20] = "v4-wlan0"; char if_name2[20] = "v4-wlan0";
ifaddrs* list = nullptr; ifaddrs* list = nullptr;

1
sdk/android/native_unittests/android_network_monitor_unittest.cc
View File

@ -127,7 +127,6 @@ TEST_F(AndroidNetworkMonitorTest,
} }
TEST_F(AndroidNetworkMonitorTest, TestFindNetworkHandleUsingIfName) { TEST_F(AndroidNetworkMonitorTest, TestFindNetworkHandleUsingIfName) {
ScopedFieldTrials field_trials("WebRTC-BindUsingInterfaceName/Enabled/");
// Start() updates the states introduced by the field trial. // Start() updates the states introduced by the field trial.
network_monitor_->Start(); network_monitor_->Start();
jni::NetworkHandle ipv6_handle = 200; jni::NetworkHandle ipv6_handle = 200;

2
sdk/android/src/jni/android_network_monitor.cc
View File

@ -247,7 +247,7 @@ void AndroidNetworkMonitor::Start() {
webrtc::field_trial::IsEnabled( webrtc::field_trial::IsEnabled(
"WebRTC-FindNetworkHandleWithoutIpv6TemporaryPart"); "WebRTC-FindNetworkHandleWithoutIpv6TemporaryPart");
bind_using_ifname_ = bind_using_ifname_ =
webrtc::field_trial::IsEnabled("WebRTC-BindUsingInterfaceName"); !webrtc::field_trial::IsDisabled("WebRTC-BindUsingInterfaceName");
// This pointer is also accessed by the methods called from java threads. // This pointer is also accessed by the methods called from java threads.
// Assigning it here is safe, because the java monitor is in a stopped state, // Assigning it here is safe, because the java monitor is in a stopped state,