From b5b159d98c0781ef7823d03061c374367cde66f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= Date: Tue, 5 Jul 2022 09:59:27 +0200 Subject: [PATCH] Update old TODO comments Bug: None Change-Id: I531ed648fe3d1f0dd1202f53c59ed023aed1ea7c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267664 Commit-Queue: Niels Moller Reviewed-by: Harald Alvestrand Cr-Commit-Position: refs/heads/main@{#37432} --- pc/legacy_stats_collector.cc | 4 ++-- pc/rtp_sender.h | 4 ++-- pc/test/fake_peer_connection_base.h | 2 -- sdk/android/api/org/webrtc/YuvConverter.java | 4 +--- sdk/android/src/jni/scoped_java_ref_counted.h | 1 - .../e2e/stats_based_network_quality_metrics_reporter.h | 5 +++-- video/rtp_video_stream_receiver2.cc | 10 +++++----- video/video_quality_test.cc | 1 - video/video_stream_encoder.cc | 1 - 9 files changed, 13 insertions(+), 19 deletions(-) diff --git a/pc/legacy_stats_collector.cc b/pc/legacy_stats_collector.cc index 444bb3b039..393e0efe7e 100644 --- a/pc/legacy_stats_collector.cc +++ b/pc/legacy_stats_collector.cc @@ -1245,8 +1245,8 @@ void LegacyStatsCollector::ExtractSenderInfo() { RTC_DCHECK_RUN_ON(pc_->signaling_thread()); for (const auto& sender : pc_->GetSenders()) { - // TODO(nisse): SSRC == 0 currently means none. Delete check when - // that is fixed. + // TODO(bugs.webrtc.org/8694): SSRC == 0 currently means none. Delete check + // when that is fixed. if (!sender->ssrc()) { continue; } diff --git a/pc/rtp_sender.h b/pc/rtp_sender.h index 95f68e3d3a..f552df0a3b 100644 --- a/pc/rtp_sender.h +++ b/pc/rtp_sender.h @@ -201,8 +201,8 @@ class RtpSenderBase : public RtpSenderInternal, public ObserverInterface { RtpSenderBase(rtc::Thread* worker_thread, const std::string& id, SetStreamsObserver* set_streams_observer); - // TODO(nisse): Since SSRC == 0 is technically valid, figure out - // some other way to test if we have a valid SSRC. + // TODO(bugs.webrtc.org/8694): Since SSRC == 0 is technically valid, figure + // out some other way to test if we have a valid SSRC. bool can_send_track() const { return track_ && ssrc_; } virtual std::string track_kind() const = 0; diff --git a/pc/test/fake_peer_connection_base.h b/pc/test/fake_peer_connection_base.h index 8363f4d8bf..9ee69be993 100644 --- a/pc/test/fake_peer_connection_base.h +++ b/pc/test/fake_peer_connection_base.h @@ -28,8 +28,6 @@ namespace webrtc { // FakePeerConnectionBase then overriding the interesting methods. This class // takes care of providing default implementations for all the pure virtual // functions specified in the interfaces. -// TODO(nisse): Try to replace this with DummyPeerConnection, from -// api/test/ ? class FakePeerConnectionBase : public PeerConnectionInternal { public: // PeerConnectionInterface implementation. diff --git a/sdk/android/api/org/webrtc/YuvConverter.java b/sdk/android/api/org/webrtc/YuvConverter.java index ab9688a43f..c855d4be41 100644 --- a/sdk/android/api/org/webrtc/YuvConverter.java +++ b/sdk/android/api/org/webrtc/YuvConverter.java @@ -36,9 +36,7 @@ public final class YuvConverter { // Since the alpha read from the texture is always 1, this could // be written as a mat4 x vec4 multiply. However, that seems to // give a worse framerate, possibly because the additional - // multiplies by 1.0 consume resources. TODO(nisse): Could also - // try to do it as a vec3 x mat3x4, followed by an add in of a - // constant vector. + // multiplies by 1.0 consume resources. + " gl_FragColor.r = coeffs.a + dot(coeffs.rgb,\n" + " sample(tc - 1.5 * xUnit).rgb);\n" + " gl_FragColor.g = coeffs.a + dot(coeffs.rgb,\n" diff --git a/sdk/android/src/jni/scoped_java_ref_counted.h b/sdk/android/src/jni/scoped_java_ref_counted.h index 4f8f1831b4..3ea226259e 100644 --- a/sdk/android/src/jni/scoped_java_ref_counted.h +++ b/sdk/android/src/jni/scoped_java_ref_counted.h @@ -30,7 +30,6 @@ class ScopedJavaRefCounted { const JavaRef& j_object); ScopedJavaRefCounted(ScopedJavaRefCounted&& other) = default; - // TODO(nisse): Implement move assignment and copy operations when needed. ScopedJavaRefCounted(const ScopedJavaRefCounted& other) = delete; ScopedJavaRefCounted& operator=(const ScopedJavaRefCounted&) = delete; diff --git a/test/pc/e2e/stats_based_network_quality_metrics_reporter.h b/test/pc/e2e/stats_based_network_quality_metrics_reporter.h index 50096165fa..a940d81df8 100644 --- a/test/pc/e2e/stats_based_network_quality_metrics_reporter.h +++ b/test/pc/e2e/stats_based_network_quality_metrics_reporter.h @@ -58,8 +58,9 @@ class StatsBasedNetworkQualityMetricsReporter private: struct PCStats { - // TODO(nisse): Separate audio and video counters. Depends on standard stat - // counters, enabled by field trial "WebRTC-UseStandardBytesStats". + // TODO(bugs.webrtc.org/10525): Separate audio and video counters. Depends + // on standard stat counters, enabled by field trial + // "WebRTC-UseStandardBytesStats". DataSize payload_received = DataSize::Zero(); DataSize payload_sent = DataSize::Zero(); diff --git a/video/rtp_video_stream_receiver2.cc b/video/rtp_video_stream_receiver2.cc index 1ed460764d..afc51fbea2 100644 --- a/video/rtp_video_stream_receiver2.cc +++ b/video/rtp_video_stream_receiver2.cc @@ -646,11 +646,11 @@ void RtpVideoStreamReceiver2::OnRecoveredPacket(const uint8_t* rtp_packet, packet.IdentifyExtensions(rtp_header_extensions_); packet.set_payload_type_frequency(kVideoPayloadTypeFrequency); - // TODO(nisse): UlpfecReceiverImpl::ProcessReceivedFec passes both - // original (decapsulated) media packets and recovered packets to - // this callback. We need a way to distinguish, for setting - // packet.recovered() correctly. Ideally, move RED decapsulation out - // of the Ulpfec implementation. + // TODO(bugs.webrtc.org/7135): UlpfecReceiverImpl::ProcessReceivedFec passes + // both original (decapsulated) media packets and recovered packets to this + // callback. We need a way to distinguish, for setting packet.recovered() + // correctly. Ideally, move RED decapsulation out of the Ulpfec + // implementation. ReceivePacket(packet); } diff --git a/video/video_quality_test.cc b/video/video_quality_test.cc index 8c3906564e..087eb3c6af 100644 --- a/video/video_quality_test.cc +++ b/video/video_quality_test.cc @@ -954,7 +954,6 @@ void VideoQualityTest::SetupThumbnails(Transport* send_transport, // sender_call. VideoSendStream::Config thumbnail_send_config(recv_transport); thumbnail_send_config.rtp.ssrcs.push_back(kThumbnailSendSsrcStart + i); - // TODO(nisse): Could use a simpler VP8-only encoder factory. thumbnail_send_config.encoder_settings.encoder_factory = &video_encoder_factory_; thumbnail_send_config.encoder_settings.bitrate_allocator_factory = diff --git a/video/video_stream_encoder.cc b/video/video_stream_encoder.cc index 0cc56f5521..d77cbe42aa 100644 --- a/video/video_stream_encoder.cc +++ b/video/video_stream_encoder.cc @@ -2274,7 +2274,6 @@ void VideoStreamEncoder::RunPostEncode(const EncodedImage& encoded_image, absl::optional encode_duration_us; if (encoded_image.timing_.flags != VideoSendTiming::kInvalid) { encode_duration_us = - // TODO(nisse): Maybe use capture_time_ms_ rather than encode_start_ms_? TimeDelta::Millis(encoded_image.timing_.encode_finish_ms - encoded_image.timing_.encode_start_ms) .us();