zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

GN: Change rtc_source_set targets --> rtc_static_library

Browse Source 
This changes most non-test related rtc_source_set targets to be
rtc_static_library instead. Targets without any .cc files are excluded.
This should bring back the build behavior we used to have with GYP
(i.e. same symbols exported in the libjingle_peerconnection.a file, which
are used by some downstream projects).

After doing an Android build with these changes:
$ nm --defined-only -g -C out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i createpeerconnectionf
00077c51 T Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory
$ nm --defined-only -g -C out/Release/obj/webrtc/api/libjingle_peerconnection.a | grep -i createpeerconnectionf
00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*, rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*, cricket::WebRtcVideoDecoderFactory*)
00000001 T webrtc::CreatePeerConnectionFactory()

See https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookbook.md#Note-on-static-libraries
for more details on this.

NOTICE: This should be further cleaned up in the future, to reduce
binary bloat and unnecessary linking time. Right now it's more
important to restore the desired build output though.

BUG=webrtc:6410, chromium:630755

Review-Url: https://codereview.webrtc.org/2361623004
Cr-Commit-Position: refs/heads/master@{#14364}
This commit is contained in:
kjellander
2016-09-23 00:38:52 -07:00
committed by Commit bot
parent 25f6a39181
commit b62dbbe985
36 changed files with 91 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/modules/video_processing/BUILD.gn
View File

@ -11,7 +11,7 @@ import("../../build/webrtc.gni")
build_video_processing_sse2 = current_cpu == "x86" || current_cpu == "x64"
rtc_source_set("video_processing") {
rtc_static_library("video_processing") {
sources = [
"frame_preprocessor.cc",
"frame_preprocessor.h",
@ -56,7 +56,7 @@ rtc_source_set("video_processing") {
}
if (build_video_processing_sse2) {
rtc_source_set("video_processing_sse2") {
rtc_static_library("video_processing_sse2") {
sources = [
"util/denoiser_filter_sse2.cc",
"util/denoiser_filter_sse2.h",
@ -75,7 +75,7 @@ if (build_video_processing_sse2) {
}
if (rtc_build_with_neon) {
rtc_source_set("video_processing_neon") {
rtc_static_library("video_processing_neon") {
sources = [
"util/denoiser_filter_neon.cc",
"util/denoiser_filter_neon.h",