Fix and test CreateVideoStreamDecoder

create TaskQueue using provided factory instead of through constructor that uses GlobalTaskQueueFactory
Rename interface to avoid collision with class in video/video_stream_decoder.h
Add simple unittest to avoid future breakages.

Bug: webrtc:10284, webrtc:10521
Change-Id: I647b31cc99a2b6beb79b936f05f482788861f1cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131398
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27503}
This commit is contained in:
Danil Chapovalov
2019-04-08 16:59:28 +02:00
committed by Commit Bot
parent 25b96122ec
commit b703db9bce
8 changed files with 88 additions and 11 deletions

View File

@ -14,11 +14,15 @@
#include "video/video_stream_decoder_impl.h"
namespace webrtc {
std::unique_ptr<VideoStreamDecoder> CreateVideoStreamDecoder(
VideoStreamDecoder::Callbacks* callbacks,
std::unique_ptr<VideoStreamDecoderInterface> CreateVideoStreamDecoder(
VideoStreamDecoderInterface::Callbacks* callbacks,
VideoDecoderFactory* decoder_factory,
TaskQueueFactory* task_queue_factory,
std::map<int, std::pair<SdpVideoFormat, int>> decoder_settings) {
return absl::make_unique<VideoStreamDecoderImpl>(callbacks, decoder_factory,
task_queue_factory,
std::move(decoder_settings));
}
} // namespace webrtc