Enable send-side BWE by default for video in call tests.
Also fixes a bug where RTCP transport feedback was sent even though RTCP was disabled. May affect perf numbers since the behavior of the send-side BWE differs a lot from the recv-side BWE. BUG=webrtc:7111 Review-Url: https://codereview.webrtc.org/2669413003 Cr-Commit-Position: refs/heads/master@{#16451}
This commit is contained in:
@ -1049,6 +1049,12 @@ bool RTCPSender::SendFeedbackPacket(const rtcp::TransportFeedback& packet) {
|
||||
// but we can't because of an incorrect warning (C4822) in MVS 2013.
|
||||
} sender(transport_, event_log_);
|
||||
|
||||
{
|
||||
rtc::CritScope lock(&critical_section_rtcp_sender_);
|
||||
if (method_ == RtcpMode::kOff)
|
||||
return false;
|
||||
}
|
||||
|
||||
RTC_DCHECK_LE(max_packet_size_, IP_PACKET_SIZE);
|
||||
uint8_t buffer[IP_PACKET_SIZE];
|
||||
return packet.BuildExternalBuffer(buffer, max_packet_size_, &sender) &&
|
||||
|
||||
Reference in New Issue
Block a user