zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable flaky tests on iOS

Browse Source 
Tests disabled:
CurrentSpeakerMonitorTest.SpeakerChange
TargetDelayTest.OutOfRangeInput
TargetDelayTest.NoTargetDelayBufferSizeChanges
TargetDelayTest.WithTargetDelayBufferNotChanging
TargetDelayTest.RequiredDelayAtCorrectRange
TargetDelayTest.TargetDelayBufferMinMax

BUG=webrtc:7057
TBR=aleloi@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2717993002
Cr-Commit-Position: refs/heads/master@{#16850}
This commit is contained in:
kjellander
2017-02-26 22:10:14 -08:00
committed by Commit bot
parent 7c85658556
commit b7d24f6d8d
2 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
webrtc/modules/audio_coding/test/target_delay_unittest.cc
View File

@ -201,7 +201,8 @@ class TargetDelayTest : public ::testing::Test {
uint8_t payload_[kPayloadLenBytes]; uint8_t payload_[kPayloadLenBytes];
}; };
#if defined(WEBRTC_ANDROID) // Flaky on iOS: webrtc:7057.
#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS)
#define MAYBE_OutOfRangeInput DISABLED_OutOfRangeInput #define MAYBE_OutOfRangeInput DISABLED_OutOfRangeInput
#else #else
#define MAYBE_OutOfRangeInput OutOfRangeInput #define MAYBE_OutOfRangeInput OutOfRangeInput
@ -210,7 +211,8 @@ TEST_F(TargetDelayTest, MAYBE_OutOfRangeInput) {
OutOfRangeInput(); OutOfRangeInput();
} }
#if defined(WEBRTC_ANDROID) // Flaky on iOS: webrtc:7057.
#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS)
#define MAYBE_NoTargetDelayBufferSizeChanges \ #define MAYBE_NoTargetDelayBufferSizeChanges \
DISABLED_NoTargetDelayBufferSizeChanges DISABLED_NoTargetDelayBufferSizeChanges
#else #else
@ -220,7 +222,8 @@ TEST_F(TargetDelayTest, MAYBE_NoTargetDelayBufferSizeChanges) {
NoTargetDelayBufferSizeChanges(); NoTargetDelayBufferSizeChanges();
} }
#if defined(WEBRTC_ANDROID) // Flaky on iOS: webrtc:7057.
#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS)
#define MAYBE_WithTargetDelayBufferNotChanging \ #define MAYBE_WithTargetDelayBufferNotChanging \
DISABLED_WithTargetDelayBufferNotChanging DISABLED_WithTargetDelayBufferNotChanging
#else #else
@ -230,7 +233,8 @@ TEST_F(TargetDelayTest, MAYBE_WithTargetDelayBufferNotChanging) {
WithTargetDelayBufferNotChanging(); WithTargetDelayBufferNotChanging();
} }
#if defined(WEBRTC_ANDROID) // Flaky on iOS: webrtc:7057.
#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS)
#define MAYBE_RequiredDelayAtCorrectRange DISABLED_RequiredDelayAtCorrectRange #define MAYBE_RequiredDelayAtCorrectRange DISABLED_RequiredDelayAtCorrectRange
#else #else
#define MAYBE_RequiredDelayAtCorrectRange RequiredDelayAtCorrectRange #define MAYBE_RequiredDelayAtCorrectRange RequiredDelayAtCorrectRange
@ -239,7 +243,8 @@ TEST_F(TargetDelayTest, MAYBE_RequiredDelayAtCorrectRange) {
RequiredDelayAtCorrectRange(); RequiredDelayAtCorrectRange();
} }
#if defined(WEBRTC_ANDROID) // Flaky on iOS: webrtc:7057.
#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS)
#define MAYBE_TargetDelayBufferMinMax DISABLED_TargetDelayBufferMinMax #define MAYBE_TargetDelayBufferMinMax DISABLED_TargetDelayBufferMinMax
#else #else
#define MAYBE_TargetDelayBufferMinMax TargetDelayBufferMinMax #define MAYBE_TargetDelayBufferMinMax TargetDelayBufferMinMax

8
webrtc/pc/currentspeakermonitor_unittest.cc
View File

@ -122,7 +122,13 @@ TEST_F(CurrentSpeakerMonitorTest, DISABLED_RapidSpeakerChange) {
EXPECT_EQ(num_changes_, 1); EXPECT_EQ(num_changes_, 1);
} }
TEST_F(CurrentSpeakerMonitorTest, SpeakerChange) { // Flaky on iOS: webrtc:7057.
#if defined(WEBRTC_IOS)
#define MAYBE_SpeakerChange DISABLED_SpeakerChange
#else
#define MAYBE_SpeakerChange SpeakerChange
#endif
TEST_F(CurrentSpeakerMonitorTest, MAYBE_SpeakerChange) {
AudioInfo info; AudioInfo info;
InitAudioInfo(&info, 0, 0); InitAudioInfo(&info, 0, 0);