Clean up visibility and dependencies of RTC event log build targets.
- Remove visibility of encoder target. - Remove unnecessary dependency on task_queue. - Remove CreateRtcEventLogFactory() declaration from the rtc_event_log_api target since the function is not defined in that target. Bug: None Change-Id: Id9edee86f358d08ea063d62bd96e9653c5b06d55 Reviewed-on: https://webrtc-review.googlesource.com/c/116060 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26215}
This commit is contained in:

committed by
Commit Bot

parent
e4ed6ea63b
commit
b8b3c9918f
@ -41,7 +41,6 @@ rtc_source_set("rtc_event_log_api") {
|
||||
"../api:libjingle_logging_api",
|
||||
"../rtc_base:ptr_util",
|
||||
"../rtc_base:rtc_base_approved",
|
||||
"../rtc_base:rtc_task_queue",
|
||||
"//third_party/abseil-cpp/absl/memory",
|
||||
]
|
||||
}
|
||||
@ -158,7 +157,6 @@ rtc_source_set("rtc_event_video") {
|
||||
# TODO(eladalon): Break down into (1) encoder and (2) decoder; we don't need
|
||||
# the decoder code in the WebRTC library, only in unit tests and tools.
|
||||
rtc_static_library("rtc_event_log_impl_encoder") {
|
||||
visibility = [ "*" ]
|
||||
sources = [
|
||||
"rtc_event_log/encoder/blob_encoding.cc",
|
||||
"rtc_event_log/encoder/blob_encoding.h",
|
||||
@ -225,6 +223,8 @@ rtc_source_set("rtc_event_log_impl_output") {
|
||||
}
|
||||
|
||||
rtc_static_library("rtc_event_log_impl_base") {
|
||||
# TODO(terelius): Should this really be visible? Currently used to instantiate
|
||||
# the default event log factory.
|
||||
visibility = [ "*" ]
|
||||
sources = [
|
||||
"rtc_event_log/rtc_event_log_factory.cc",
|
||||
|
@ -16,7 +16,6 @@
|
||||
|
||||
#include "api/rtceventlogoutput.h"
|
||||
#include "logging/rtc_event_log/events/rtc_event.h"
|
||||
#include "rtc_base/task_queue.h"
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
@ -15,7 +15,6 @@
|
||||
|
||||
#include "logging/rtc_event_log/rtc_event_log.h"
|
||||
#include "logging/rtc_event_log/rtc_event_log_factory_interface.h"
|
||||
#include "rtc_base/task_queue.h"
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
|
@ -14,7 +14,6 @@
|
||||
#include <memory>
|
||||
|
||||
#include "logging/rtc_event_log/rtc_event_log.h"
|
||||
#include "rtc_base/task_queue.h"
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
@ -29,8 +28,6 @@ class RtcEventLogFactoryInterface {
|
||||
RtcEventLog::EncodingType encoding_type) = 0;
|
||||
};
|
||||
|
||||
std::unique_ptr<RtcEventLogFactoryInterface> CreateRtcEventLogFactory();
|
||||
|
||||
} // namespace webrtc
|
||||
|
||||
#endif // LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_FACTORY_INTERFACE_H_
|
||||
|
Reference in New Issue
Block a user