zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Write protos as binary.

Browse Source 
We need to write protos as "wb" and not "w", otherwise we get CRLF
on Windows which corrupts the proto.

Bug: chromium:1029452
Change-Id: Iabf841405134d7bc2523ac48219ca7cb9d8214c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170320
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30772}
This commit is contained in:
Patrik Höglund
2020-03-12 09:39:40 +01:00
committed by Commit Bot
parent f092e4d0ff
commit b8e69efcee
7 changed files with 41 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
test/testsupport/perf_test.h
View File

@ -105,8 +105,9 @@ std::string GetPerfResults();
// they will be skipped.
void PrintPlottableResults(const std::vector<std::string>& desired_graphs);
// Call GetPerfResults() and write its output to a file.
void WritePerfResults(const std::string& output_path);
// Call GetPerfResults() and write its output to a file. Returns false if we
// failed to write to the file.
bool WritePerfResults(const std::string& output_path);
// By default, perf results are printed to stdout. Set the FILE* to where they
// should be printing instead.