Reland of Delete video_render module. (patchset #1 id:1 of https://codereview.webrtc.org/1923613003/ )
Reason for revert: Chrome's build files have now been updated, see cl https://codereview.chromium.org/1929933002/ Original issue's description: > Revert of Delete video_render module. (patchset #12 id:220001 of https://codereview.webrtc.org/1912143002/ ) > > Reason for revert: > This breaks every buildbot in chromium.webrtc.fyi and I don't see any roll in progress to address this (and I don't see how that would be possible either). > Usage in Chrome: https://code.google.com/p/chromium/codesearch#search/&q=modules.gyp%3Avideo_render&sq=package:chromium&type=cs > > Example failures: > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/5420 > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/4526 > > I think it's fine to delete our video_render_module_internal_impl target and those files, but video_render target needs to remain. > > Original issue's description: > > Delete video_render module. > > > > BUG=webrtc:5817 > > > > Committed: https://crrev.com/97cfd1ec05d07ef233356e57f7aa4b028b74ffba > > Cr-Commit-Position: refs/heads/master@{#12526} > > TBR=mflodman@webrtc.org,pbos@webrtc.org,nisse@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5817 TBR=mflodman@webrtc.org,pbos@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5817 Review-Url: https://codereview.webrtc.org/1929223003 Cr-Commit-Position: refs/heads/master@{#12556}
This commit is contained in:
@ -18,14 +18,5 @@
|
||||
|
||||
'includes': [ '../../build/java.gypi' ],
|
||||
}, # audio_device_module_java
|
||||
{
|
||||
'target_name': 'video_render_module_java',
|
||||
'type': 'none',
|
||||
'variables': {
|
||||
'java_in_dir': 'video_render/android/java',
|
||||
'additional_src_dirs': [ '../base/java/src', ],
|
||||
},
|
||||
'includes': [ '../../build/java.gypi' ],
|
||||
}, # video_render_module_java
|
||||
],
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user