zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Creating webrtc/modules:module_api (patchset #5 id:80001 of https://codereview.webrtc.org/2838873002/ )

Browse Source 
Reason for revert:
Causes build problem: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28iOS%209.0%29/builds/1630/steps/generate%20build%20files%20%28mb%29/logs/stdio

Original issue's description:
> Creating webrtc/modules:module_api
>
> This target keeps track of .h the files under webrtc/modules/include/
> that are not part of any target.
> If a .h file is not part of a target the 'gn check' utility is not
> able to spot if a target is missing a dependency because even if
> it parses '#include' directives it is not able to find a target that
> contains these headers.
>
> BUG=webrtc:7513
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/2838873002
> Cr-Commit-Position: refs/heads/master@{#17880}
> Committed: 5a1a092ed0

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7513

Review-Url: https://codereview.webrtc.org/2839963005
Cr-Commit-Position: refs/heads/master@{#17881}
This commit is contained in:
mbonadei
2017-04-26 02:00:16 -07:00
committed by Commit bot
parent 5a1a092ed0
commit bb08c3e296
22 changed files with 3 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
webrtc/modules/video_coding/BUILD.gn
View File

@ -94,7 +94,6 @@ rtc_static_library("video_coding") {
":webrtc_i420",
":webrtc_vp8",
":webrtc_vp9",
"..:module_api",
"../..:video_stream_api",
"../..:webrtc_common",
"../../base:rtc_base",
@ -130,7 +129,6 @@ rtc_static_library("video_coding_utility") {
}
deps = [
"..:module_api",
"../..:webrtc_common",
"../../api/video_codecs:video_codecs_api",
"../../base:rtc_base_approved",
@ -227,7 +225,6 @@ rtc_static_library("webrtc_vp8") {
deps = [
":video_coding_utility",
"..:module_api",
"../..:webrtc_common",
"../../api/video_codecs:video_codecs_api",
"../../base:rtc_base_approved",
@ -263,7 +260,6 @@ rtc_static_library("webrtc_vp9") {
deps = [
":video_coding_utility",
"..:module_api",
"../../base:rtc_base_approved",
"../../common_video",
"../../system_wrappers",
@ -547,7 +543,6 @@ if (rtc_include_tests) {
":webrtc_h264",
":webrtc_vp8",
":webrtc_vp9",
"..:module_api",
"../..:webrtc_common",
"../../api:video_frame_api",
"../../api/video_codecs:video_codecs_api",