zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove empty-string comparisons.

Browse Source 
Use .empty() and !.empty() in favor of == "" or != "".

BUG=
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1228913003

Cr-Commit-Position: refs/heads/master@{#9559}
This commit is contained in:
pbos
2015-07-09 07:48:14 -07:00
committed by Commit bot
parent 3b1e647b6a
commit bb36fdf95f
12 changed files with 20 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
webrtc/video/replay.cc
View File

@ -106,7 +106,7 @@ static const bool timestamp_offset_dummy =
// Flag for rtpdump input file.
bool ValidateInputFilenameNotEmpty(const char* flagname,
const std::string& string) {
return string != "";
return !string.empty();
}
DEFINE_string(input_file, "", "input file");
@ -156,7 +156,7 @@ class FileRenderPassthrough : public VideoRenderer {
int time_to_render_ms) override {
if (renderer_ != nullptr)
renderer_->RenderFrame(video_frame, time_to_render_ms);
if (basename_ == "")
if (basename_.empty())
return;
if (last_width_ != video_frame.width() ||
last_height_ != video_frame.height()) {
@ -241,13 +241,13 @@ void RtpReplay() {
encoder_settings.payload_type = flags::PayloadType();
VideoReceiveStream::Decoder decoder;
rtc::scoped_ptr<DecoderBitstreamFileWriter> bitstream_writer;
if (flags::DecoderBitstreamFilename() != "") {
if (!flags::DecoderBitstreamFilename().empty()) {
bitstream_writer.reset(new DecoderBitstreamFileWriter(
flags::DecoderBitstreamFilename().c_str()));
receive_config.pre_decode_callback = bitstream_writer.get();
}
decoder = test::CreateMatchingDecoder(encoder_settings);
if (flags::DecoderBitstreamFilename() != "") {
if (!flags::DecoderBitstreamFilename().empty()) {
// Replace with a null decoder if we're writing the bitstream to a file
// instead.
delete decoder.decoder;