zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable broken Android rtc_unittests.

Browse Source 
After disabling all of these, the rest of the tests pass, at least on
my Nexus 7 device.

BUG=webrtc:4364

Review-Url: https://codereview.webrtc.org/2151823002
Cr-Commit-Position: refs/heads/master@{#13485}
This commit is contained in:
phoglund
2016-07-15 03:57:12 -07:00
committed by Commit bot
parent 9d34148714
commit bb738733ea
4 changed files with 66 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
webrtc/base/fileutils_unittest.cc
View File

@ -17,14 +17,21 @@
namespace rtc {
#if defined (WEBRTC_ANDROID)
// Fails on Android: https://bugs.chromium.org/p/webrtc/issues/detail?id=4364.
#define MAYBE_FilesystemTest DISABLED_FilesystemTest
#else
#define MAYBE_FilesystemTest FilesystemTest
#endif
// Make sure we can get a temp folder for the later tests.
TEST(FilesystemTest, GetTemporaryFolder) {
TEST(MAYBE_FilesystemTest, GetTemporaryFolder) {
Pathname path;
EXPECT_TRUE(Filesystem::GetTemporaryFolder(path, true, NULL));
}
// Test creating a temp file, reading it back in, and deleting it.
TEST(FilesystemTest, TestOpenFile) {
TEST(MAYBE_FilesystemTest, TestOpenFile) {
Pathname path;
EXPECT_TRUE(Filesystem::GetTemporaryFolder(path, true, NULL));
path.SetPathname(Filesystem::TempFilename(path, "ut"));
@ -52,7 +59,7 @@ TEST(FilesystemTest, TestOpenFile) {
}
// Test opening a non-existent file.
TEST(FilesystemTest, TestOpenBadFile) {
TEST(MAYBE_FilesystemTest, TestOpenBadFile) {
Pathname path;
EXPECT_TRUE(Filesystem::GetTemporaryFolder(path, true, NULL));
path.SetFilename("not an actual file");
@ -65,7 +72,7 @@ TEST(FilesystemTest, TestOpenBadFile) {
// Test that CreatePrivateFile fails for existing files and succeeds for
// non-existent ones.
TEST(FilesystemTest, TestCreatePrivateFile) {
TEST(MAYBE_FilesystemTest, TestCreatePrivateFile) {
Pathname path;
EXPECT_TRUE(Filesystem::GetTemporaryFolder(path, true, NULL));
path.SetFilename("private_file_test");
@ -86,7 +93,7 @@ TEST(FilesystemTest, TestCreatePrivateFile) {
}
// Test checking for free disk space.
TEST(FilesystemTest, TestGetDiskFreeSpace) {
TEST(MAYBE_FilesystemTest, TestGetDiskFreeSpace) {
// Note that we should avoid picking any file/folder which could be located
// at the remotely mounted drive/device.
Pathname path;
@ -119,12 +126,12 @@ TEST(FilesystemTest, TestGetDiskFreeSpace) {
}
// Tests that GetCurrentDirectory() returns something.
TEST(FilesystemTest, TestGetCurrentDirectory) {
TEST(MAYBE_FilesystemTest, TestGetCurrentDirectory) {
EXPECT_FALSE(Filesystem::GetCurrentDirectory().empty());
}
// Tests that GetAppPathname returns something.
TEST(FilesystemTest, TestGetAppPathname) {
TEST(MAYBE_FilesystemTest, TestGetAppPathname) {
Pathname path;
EXPECT_TRUE(Filesystem::GetAppPathname(&path));
EXPECT_FALSE(path.empty());