zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Using fully qualified #include paths in g722 code.

Browse Source 
WebRTC internal code should always use include paths that start
from the root of the project and that clearly identify the header file.

This allows 'gn check' to actually keep dependencies under control
because 'gn check' cannot enforce anything if the include path
is not fully qualified (starting from the root of the project).

Bug: webrtc:8815
Change-Id: I1fc4cb50d81522a486888a626d4a95df7847d591
Reviewed-on: https://webrtc-review.googlesource.com/46743
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21849}
This commit is contained in:
Mirko Bonadei
2018-02-01 14:30:53 +01:00
committed by Commit Bot
parent 2bf82c1842
commit bc3b782813
3 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/audio_coding/codecs/g722/g722_decode.c
View File

@ -34,7 +34,7 @@
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include "g722_enc_dec.h" #include "modules/audio_coding/codecs/g722/g722_enc_dec.h"
#include "typedefs.h" // NOLINT(build/include) #include "typedefs.h" // NOLINT(build/include)
#if !defined(FALSE) #if !defined(FALSE)

2
modules/audio_coding/codecs/g722/g722_encode.c
View File

@ -34,7 +34,7 @@
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include "g722_enc_dec.h" #include "modules/audio_coding/codecs/g722/g722_enc_dec.h"
#include "typedefs.h" // NOLINT(build/include) #include "typedefs.h" // NOLINT(build/include)
#if !defined(FALSE) #if !defined(FALSE)

8
modules/audio_coding/codecs/g722/g722_interface.c
View File

@ -8,12 +8,11 @@
* be found in the AUTHORS file in the root of the source tree. * be found in the AUTHORS file in the root of the source tree.
*/ */
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include "g722_enc_dec.h"
#include "g722_interface.h" #include "modules/audio_coding/codecs/g722/g722_enc_dec.h"
#include "modules/audio_coding/codecs/g722/g722_interface.h"
#include "typedefs.h" // NOLINT(build/include) #include "typedefs.h" // NOLINT(build/include)
int16_t WebRtcG722_CreateEncoder(G722EncInst **G722enc_inst) int16_t WebRtcG722_CreateEncoder(G722EncInst **G722enc_inst)
@ -104,4 +103,3 @@ int16_t WebRtcG722_Version(char *versionStr, short len)
return -1; return -1;
} }
} }