From bc8ee336582be9ad2b69285c257dfe7837fa2c8d Mon Sep 17 00:00:00 2001 From: Noah Richards Date: Fri, 7 Jul 2017 13:22:45 -0700 Subject: [PATCH] Remove verbose logs from audio_coding_module.cc. PlayoutFrequency(), at least, is called ~200 times a second. The others appear to not be in practice, but it's unclear what value they serve. They were traces before https://chromium-review.googlesource.com/c/518133/, which was more reasonable, as you could enable them for just audio coding traces. But now that they are just logs, they make all VERBOSE logging unusable. Bug: webrtc:7959 Change-Id: I190a61c8ff4c0f047798087e80adbb41d791fc29 Reviewed-on: https://chromium-review.googlesource.com/563881 Reviewed-by: Minyue Li Commit-Queue: Noah Richards Cr-Commit-Position: refs/heads/master@{#18956} --- webrtc/modules/audio_coding/acm2/audio_coding_module.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/webrtc/modules/audio_coding/acm2/audio_coding_module.cc b/webrtc/modules/audio_coding/acm2/audio_coding_module.cc index efdfcd472b..be8b1d91d8 100644 --- a/webrtc/modules/audio_coding/acm2/audio_coding_module.cc +++ b/webrtc/modules/audio_coding/acm2/audio_coding_module.cc @@ -636,11 +636,10 @@ rtc::Optional AudioCodingModuleImpl::SendCodec() const { // Get current send frequency. int AudioCodingModuleImpl::SendFrequency() const { - LOG(LS_VERBOSE) << "SendFrequency()"; rtc::CritScope lock(&acm_crit_sect_); if (!encoder_stack_) { - LOG(LS_VERBOSE) << "SendFrequency Failed, no codec is registered"; + LOG(LS_ERROR) << "SendFrequency Failed, no codec is registered"; return -1; } @@ -966,7 +965,6 @@ int AudioCodingModuleImpl::ReceiveFrequency() const { // Get current playout frequency. int AudioCodingModuleImpl::PlayoutFrequency() const { - LOG(LS_VERBOSE) << "PlayoutFrequency()"; return receiver_.last_output_sample_rate_hz(); }