zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Renamed RTCStatsReport to RTCLegacyStatsReport in objc files.

Browse Source 
This is to avoid a naming conflict with webrtc::RTCStatsReport that is
surfaced if you try to include it in peerconnectioninterface.h.

Background: The current stats is very much non-spec-compliant. A new
stats collection API is underway that is meant to be spec-compliant.
Some classes in Chromium and webrtc/sdk/objc have spec-compliant names
but non-spec-compliant behavior. These are being renamed to "Legacy" so
that new spec-compliant classes can be added with the correct names.

BUG=chromium:627816
TBR=tkchin@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2313943002
Cr-Commit-Position: refs/heads/master@{#14150}
This commit is contained in:
hbos
2016-09-09 01:36:28 -07:00
committed by Commit bot
parent b0afd97d6e
commit bd3dda6c86
12 changed files with 38 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
View File

@ -23,7 +23,7 @@
@class RTCRtpReceiver;
@class RTCRtpSender;
@class RTCSessionDescription;
@class RTCStatsReport;
@class RTCLegacyStatsReport;
NS_ASSUME_NONNULL_BEGIN
@ -217,7 +217,7 @@ RTC_EXPORT
(nullable RTCMediaStreamTrack *)mediaStreamTrack
statsOutputLevel:(RTCStatsOutputLevel)statsOutputLevel
completionHandler:
(nullable void (^)(NSArray<RTCStatsReport *> *stats))completionHandler;
(nullable void (^)(NSArray<RTCLegacyStatsReport *> *stats))completionHandler;
@end