From bd7ed4bd5eb1c0bf453bb399509614548bf7fb81 Mon Sep 17 00:00:00 2001 From: Sebastian Jansson Date: Tue, 5 Mar 2019 09:14:02 +0100 Subject: [PATCH] Include sign for infinity in ToString for data units. Bug: webrtc:9709 Change-Id: I8a4ee0797dca25dc7c3c414f24ada34c8bcbd7f8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125660 Reviewed-by: Per Kjellander Commit-Queue: Sebastian Jansson Cr-Commit-Position: refs/heads/master@{#26966} --- api/units/data_rate.cc | 6 ++++-- api/units/data_size.cc | 6 ++++-- api/units/timestamp.cc | 6 ++++-- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/api/units/data_rate.cc b/api/units/data_rate.cc index edc1d22e4c..f9586c5f40 100644 --- a/api/units/data_rate.cc +++ b/api/units/data_rate.cc @@ -18,8 +18,10 @@ namespace webrtc { std::string ToString(DataRate value) { char buf[64]; rtc::SimpleStringBuilder sb(buf); - if (value.IsInfinite()) { - sb << "inf bps"; + if (value.IsPlusInfinity()) { + sb << "+inf bps"; + } else if (value.IsMinusInfinity()) { + sb << "-inf bps"; } else { if (value.bps() == 0 || value.bps() % 1000 != 0) { sb << value.bps() << " bps"; diff --git a/api/units/data_size.cc b/api/units/data_size.cc index bec57d04f4..45487dfd83 100644 --- a/api/units/data_size.cc +++ b/api/units/data_size.cc @@ -18,8 +18,10 @@ namespace webrtc { std::string ToString(DataSize value) { char buf[64]; rtc::SimpleStringBuilder sb(buf); - if (value.IsInfinite()) { - sb << "inf bytes"; + if (value.IsPlusInfinity()) { + sb << "+inf bytes"; + } else if (value.IsMinusInfinity()) { + sb << "-inf bytes"; } else { sb << value.bytes() << " bytes"; } diff --git a/api/units/timestamp.cc b/api/units/timestamp.cc index c9b6e22ae0..0b9cdd9a21 100644 --- a/api/units/timestamp.cc +++ b/api/units/timestamp.cc @@ -17,8 +17,10 @@ namespace webrtc { std::string ToString(Timestamp value) { char buf[64]; rtc::SimpleStringBuilder sb(buf); - if (value.IsInfinite()) { - sb << "inf ms"; + if (value.IsPlusInfinity()) { + sb << "+inf ms"; + } else if (value.IsMinusInfinity()) { + sb << "-inf ms"; } else { if (value.ms() % 1000 == 0) sb << value.seconds() << " s";