zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Small cleanup of rtp_rtcp testAPI tests.

Browse Source 
Delete unused member |rtp_receiver_|, and simplify a return statement.

BUG=webrtc:5565

Review-Url: https://codereview.webrtc.org/2912363002
Cr-Commit-Position: refs/heads/master@{#18354}
This commit is contained in:
nisse
2017-05-31 07:35:16 -07:00
committed by Commit Bot
parent 0a0a2f12b3
commit be3e539600
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc
View File

@ -57,11 +57,8 @@ bool LoopBackTransport::SendRtp(const uint8_t* data,
RTC_CHECK_GE(len, header.headerLength);
const size_t payload_length = len - header.headerLength;
receive_statistics_->IncomingPacket(header, len, false);
if (!rtp_receiver_->IncomingRtpPacket(header, payload, payload_length,
payload_specific, true)) {
return false;
}
return true;
return rtp_receiver_->IncomingRtpPacket(header, payload, payload_length,
payload_specific, true);
}
bool LoopBackTransport::SendRtcp(const uint8_t* data, size_t len) {
@ -105,12 +102,9 @@ class RtpRtcpAPITest : public ::testing::Test {
module_.reset(RtpRtcp::CreateRtpRtcp(configuration));
module_->SetSSRC(initial_ssrc);
rtp_payload_registry_.reset(new RTPPayloadRegistry());
rtp_receiver_.reset(RtpReceiver::CreateAudioReceiver(
&fake_clock_, NULL, NULL, rtp_payload_registry_.get()));
}
std::unique_ptr<RTPPayloadRegistry> rtp_payload_registry_;
std::unique_ptr<RtpReceiver> rtp_receiver_;
std::unique_ptr<RtpRtcp> module_;
uint32_t test_ssrc_;
uint32_t test_timestamp_;