Fix chromium warnings for SdpVideoFormat.

Bug: webrtc:163
Change-Id: I29ad3c00116692f047456df7721ba636bbb2ca89
Reviewed-on: https://webrtc-review.googlesource.com/64723
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22618}

modules/video_coding/BUILD.gn

@@ -168,6 +168,7 @@ rtc_source_set("video_codec_interface") {
     "include/video_codec_interface.h",
     "include/video_coding_defines.h",
     "include/video_error_codes.h",
+    "video_coding_defines.cc",
   ]
   deps = [
     "..:module_api",

modules/video_coding/codec_timer.cc

@@ -25,6 +25,7 @@ const int64_t kTimeLimitMs = 10000;
 
 VCMCodecTimer::VCMCodecTimer()
     : ignored_sample_count_(0), filter_(kPercentile) {}
+VCMCodecTimer::~VCMCodecTimer() = default;
 
 void VCMCodecTimer::AddTiming(int64_t decode_time_ms, int64_t now_ms) {
   // Ignore the first |kIgnoredSampleCount| samples.

modules/video_coding/codec_timer.h

@@ -22,6 +22,7 @@ namespace webrtc {
 class VCMCodecTimer {
  public:
   VCMCodecTimer();
+  ~VCMCodecTimer();
 
   // Add a new decode time to the filter.
   void AddTiming(int64_t new_decode_time_ms, int64_t now_ms);

modules/video_coding/frame_buffer2.cc

@@ -602,5 +602,9 @@ void FrameBuffer::ClearFramesAndHistory() {
   num_frames_buffered_ = 0;
 }
 
+FrameBuffer::FrameInfo::FrameInfo() = default;
+FrameBuffer::FrameInfo::FrameInfo(FrameInfo&&) = default;
+FrameBuffer::FrameInfo::~FrameInfo() = default;
+
 }  // namespace video_coding
 }  // namespace webrtc

modules/video_coding/frame_buffer2.h

@@ -80,6 +80,10 @@ class FrameBuffer {
 
  private:
   struct FrameInfo {
+    FrameInfo();
+    FrameInfo(FrameInfo&&);
+    ~FrameInfo();
+
     // The maximum number of frames that can depend on this frame.
     static constexpr size_t kMaxNumDependentFrames = 8;
 

modules/video_coding/include/video_coding_defines.h

@@ -73,12 +73,10 @@ class VCMReceiveCallback {
                                 rtc::Optional<uint8_t> qp,
                                 VideoContentType content_type) = 0;
 
-  virtual int32_t ReceivedDecodedReferenceFrame(const uint64_t pictureId) {
-    return -1;
-  }
+  virtual int32_t ReceivedDecodedReferenceFrame(const uint64_t pictureId);
   // Called when the current receive codec changes.
-  virtual void OnIncomingPayloadType(int payload_type) {}
-  virtual void OnDecoderImplementationName(const char* implementation_name) {}
+  virtual void OnIncomingPayloadType(int payload_type);
+  virtual void OnDecoderImplementationName(const char* implementation_name);
 
  protected:
   virtual ~VCMReceiveCallback() {}

modules/video_coding/video_coding_defines.cc

@@ -0,0 +1,23 @@
+/*
+ *  Copyright (c) 2018 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "modules/video_coding/include/video_coding_defines.h"
+
+namespace webrtc {
+
+int32_t VCMReceiveCallback::ReceivedDecodedReferenceFrame(
+    const uint64_t pictureId) {
+  return -1;
+}
+void VCMReceiveCallback::OnIncomingPayloadType(int payload_type) {}
+void VCMReceiveCallback::OnDecoderImplementationName(
+    const char* implementation_name) {}
+
+}  // namespace webrtc