zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove default impl of Attach/DetachAecDump.

Browse Source 
The default implementations of AudioProcessing::{AttachAecDump,
DetachAecDump} are removed and audio_processing.cc is decoupled from
aec_dump.h. After this CL, the two methods are pure virtual. The
default implementations were added because doing otherwise would break
internal projects.

Bug: webrtc:7404
Change-Id: If94f60aeefe4ad1eefed3744f857692cc645bdf4
Reviewed-on: https://chromium-review.googlesource.com/528132
Commit-Queue: Alex Loiko <aleloi@google.com>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18517}
This commit is contained in:
Alex Loiko
2017-06-08 09:45:03 +02:00
committed by Commit Bot
parent 12149bd5c7
commit be767e0f7a
2 changed files with 2 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
webrtc/modules/audio_processing/include/audio_processing.cc
View File

@ -11,9 +11,6 @@
#include "webrtc/modules/audio_processing/include/audio_processing.h" #include "webrtc/modules/audio_processing/include/audio_processing.h"
#include "webrtc/base/checks.h" #include "webrtc/base/checks.h"
#include "webrtc/modules/audio_processing/include/aec_dump.h"
// TODO(aleloi): remove AecDump header usage when internal projcets
// have updated. See https://bugs.webrtc.org/7404.
namespace webrtc { namespace webrtc {
@ -35,21 +32,4 @@ Beamforming::Beamforming(bool enabled,
target_direction(target_direction) {} target_direction(target_direction) {}
Beamforming::~Beamforming() {} Beamforming::~Beamforming() {}
// TODO(aleloi): make pure virtual when internal projects have
// updated. See https://bugs.webrtc.org/7404
void AudioProcessing::AttachAecDump(std::unique_ptr<AecDump> aec_dump) {
RTC_NOTREACHED();
}
// If no AecDump is attached, this has no effect. If an AecDump is
// attached, it's destructor is called. The d-tor may block until
// all pending logging tasks are completed.
//
// TODO(aleloi): make pure virtual when internal projects have
// updated. See https://bugs.webrtc.org/7404
void AudioProcessing::DetachAecDump() {
RTC_NOTREACHED();
}
} // namespace webrtc } // namespace webrtc

10
webrtc/modules/audio_processing/include/audio_processing.h
View File

@ -463,18 +463,12 @@ class AudioProcessing {
// with a new one. This causes the d-tor of the earlier AecDump to // with a new one. This causes the d-tor of the earlier AecDump to
// be called. The d-tor call may block until all pending logging // be called. The d-tor call may block until all pending logging
// tasks are completed. // tasks are completed.
// virtual void AttachAecDump(std::unique_ptr<AecDump> aec_dump) = 0;
// TODO(aleloi): make pure virtual when internal projects have
// updated. See https://bugs.webrtc.org/7404
virtual void AttachAecDump(std::unique_ptr<AecDump> aec_dump);
// If no AecDump is attached, this has no effect. If an AecDump is // If no AecDump is attached, this has no effect. If an AecDump is
// attached, it's destructor is called. The d-tor may block until // attached, it's destructor is called. The d-tor may block until
// all pending logging tasks are completed. // all pending logging tasks are completed.
// virtual void DetachAecDump() = 0;
// TODO(aleloi): make pure virtual when internal projects have
// updated. See https://bugs.webrtc.org/7404
virtual void DetachAecDump();
// Starts recording debugging information to a file specified by |filename|, // Starts recording debugging information to a file specified by |filename|,
// a NULL-terminated string. If there is an ongoing recording, the old file // a NULL-terminated string. If there is an ongoing recording, the old file