zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prepare to remove StartRtcEventLog and StopRtcEventLog

Browse Source 
There are some internal projects that need to be updated before we remove StartRtcEventLog and StopRtcEventLog. In this CL we take away the pure-virtuality status of the functions. After landing this, we can fix the internal projects, then land https://webrtc-review.googlesource.com/c/src/+/6782.

TBR=stefan@webrtc.org

Bug: webrtc:8111
Change-Id: Ibe495a7e7d6bf8120b1a26f056bd1443031733bf
Reviewed-on: https://webrtc-review.googlesource.com/6980
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20178}
This commit is contained in:
Elad Alon
2017-10-05 19:43:34 +02:00
committed by Commit Bot
parent 4627a339b0
commit bf35eb29b5
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
api/peerconnectioninterface.h
View File

@ -1032,16 +1032,20 @@ class PeerConnectionFactoryInterface : public rtc::RefCountInterface {
// use the equivalent function on PeerConnectionInterface.
// TODO(ivoc) Remove after Chrome is updated.
virtual bool StartRtcEventLog(rtc::PlatformFile file,
int64_t max_size_bytes) = 0;
int64_t max_size_bytes) {
return false;
}
// This function is deprecated and will be removed when Chrome is updated to
// use the equivalent function on PeerConnectionInterface.
// TODO(ivoc) Remove after Chrome is updated.
virtual bool StartRtcEventLog(rtc::PlatformFile file) = 0;
virtual bool StartRtcEventLog(rtc::PlatformFile file) {
return false;
}
// This function is deprecated and will be removed when Chrome is updated to
// use the equivalent function on PeerConnectionInterface.
// TODO(ivoc) Remove after Chrome is updated.
virtual void StopRtcEventLog() = 0;
virtual void StopRtcEventLog() {}
protected:
// Dtor and ctor protected as objects shouldn't be created or deleted via