zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove RTC_DISALLOW_COPY_AND_ASSIGN more.

Browse Source 
Bug: webrtc:13555, webrtc:13082
Change-Id: I9c07708108da0a26f5e228384fd56cef4d1540b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247300
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: (Daniel.L) Byoungchan Lee <daniel.l@hpcnt.com>
Cr-Commit-Position: refs/heads/main@{#35749}
This commit is contained in:
Byoungchan Lee
2022-01-18 09:35:48 +09:00
committed by WebRTC LUCI CQ
parent cf9899c518
commit c065e739e2
28 changed files with 100 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
logging/rtc_event_log/encoder/bit_writer.h
View File

@ -20,7 +20,6 @@
#include "absl/strings/string_view.h"
#include "rtc_base/bit_buffer.h"
#include "rtc_base/checks.h"
#include "rtc_base/constructor_magic.h"
namespace webrtc {
@ -36,6 +35,9 @@ class BitWriter final {
RTC_DCHECK_GT(byte_count, 0);
}
BitWriter(const BitWriter&) = delete;
BitWriter& operator=(const BitWriter&) = delete;
void WriteBits(uint64_t val, size_t bit_count);
void WriteBits(absl::string_view input);
@ -52,8 +54,6 @@ class BitWriter final {
// to go anywhere near the limit, though, so this is good enough.
size_t written_bits_;
bool valid_;
RTC_DISALLOW_COPY_AND_ASSIGN(BitWriter);
};
} // namespace webrtc

11
logging/rtc_event_log/encoder/delta_encoding.cc
View File

@ -21,7 +21,6 @@
#include "rtc_base/bit_buffer.h"
#include "rtc_base/bitstream_reader.h"
#include "rtc_base/checks.h"
#include "rtc_base/constructor_magic.h"
#include "rtc_base/logging.h"
#include "rtc_base/numerics/safe_conversions.h"
@ -187,6 +186,9 @@ class FixedLengthDeltaEncoder final {
absl::optional<uint64_t> base,
const std::vector<absl::optional<uint64_t>>& values);
FixedLengthDeltaEncoder(const FixedLengthDeltaEncoder&) = delete;
FixedLengthDeltaEncoder& operator=(const FixedLengthDeltaEncoder&) = delete;
private:
// Calculate min/max values of unsigned/signed deltas, given the bit width
// of all the values in the series.
@ -249,8 +251,6 @@ class FixedLengthDeltaEncoder final {
// ctor has finished running when this is constructed, so that the lower
// bound on the buffer size would be guaranteed correct.
std::unique_ptr<BitWriter> writer_;
RTC_DISALLOW_COPY_AND_ASSIGN(FixedLengthDeltaEncoder);
};
// TODO(eladalon): Reduce the number of passes.
@ -566,6 +566,9 @@ class FixedLengthDeltaDecoder final {
absl::optional<uint64_t> base,
size_t num_of_deltas);
FixedLengthDeltaDecoder(const FixedLengthDeltaDecoder&) = delete;
FixedLengthDeltaDecoder& operator=(const FixedLengthDeltaDecoder&) = delete;
private:
// Reads the encoding header in `input` and returns a FixedLengthDeltaDecoder
// with the corresponding configuration, that can be used to decode the
@ -619,8 +622,6 @@ class FixedLengthDeltaDecoder final {
// The number of values to be known to be decoded.
const size_t num_of_deltas_;
RTC_DISALLOW_COPY_AND_ASSIGN(FixedLengthDeltaDecoder);
};
bool FixedLengthDeltaDecoder::IsSuitableDecoderFor(const std::string& input) {