zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

common_audio: Removes macro WEBRTC_SPL_SHIFT_W16

Browse Source 
We should avoid macros in general (see style guide). This shift macro is not a severe one, since there is a check for negativity.

BUG=3348,3353
TESTED=trybots and manually
R=kwiberg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15799004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6591 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
bjornv@webrtc.org
2014-07-03 13:38:53 +00:00
parent 38214d53db
commit c0ba4392f1
4 changed files with 28 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
webrtc/common_audio/signal_processing/signal_processing_unittest.cc
View File

@ -79,7 +79,6 @@ TEST_F(SplTest, MacroTest) {
// Shifting with negative numbers allowed
int shift_amount = 1; // Workaround compiler warning using variable here.
// Positive means left shift
EXPECT_EQ(32766, WEBRTC_SPL_SHIFT_W16(a, shift_amount));
EXPECT_EQ(32766, WEBRTC_SPL_SHIFT_W32(a, shift_amount));
// Shifting with negative numbers not allowed