zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move AudioCodingModuleImpl to anonymous namespace in audio_coding_module.cc

Browse Source 
AudioCodingModuleImpl is the only implementation of the
AudioCodingModule interface (except for test mocks). So it's a good
fit to put it in an anonymous namespace in the interface's .cc file,
to ensure that no one except AudioCodingModule::Create ever references
it.

Except for moving code, this CL introduces two other small changes:

  * It cleans up the set of #includes in audio_coding_module.cc.
    Specifically, I removed #includes that were already present in
    audio_coding_module.h, and did not bring along any #includes from
    audio_coding_module_impl.h and .cc except those that were
    necessary to get it to compile.

  * It moves AudioCodingModuleImpl from the webrtc::acm2 to the
    webrtc::<anonymous> namespace. This means I had to qualify a few
    things it references with acm2::.

Review-Url: https://codereview.webrtc.org/2069723003
Cr-Commit-Position: refs/heads/master@{#13191}
This commit is contained in:
kwiberg
2016-06-17 06:00:45 -07:00
committed by Commit bot
parent 434b85d708
commit c13ded54ca
6 changed files with 1224 additions and 1306 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/modules/audio_coding/audio_coding.gypi
View File

@ -174,8 +174,6 @@
'acm2/acm_resampler.cc',
'acm2/acm_resampler.h',
'acm2/audio_coding_module.cc',
'acm2/audio_coding_module_impl.cc',
'acm2/audio_coding_module_impl.h',
'acm2/call_statistics.cc',
'acm2/call_statistics.h',
'acm2/codec_manager.cc',