Revert "Mark all bool conversion operators as explicit"

This reverts commit 325789c4576b60147ee1ef225d438cbb740f65ff.

Reason for revert: Breaks downstream clients.

Original change's description:
> Mark all bool conversion operators as explicit
>
> An explicit bool conversion operator will still be used implicitly
> when an expression appears in "bool context", e.g., as the condition
> in an if statement, or as argument to logical operators. The
> `explicit` annotation prevents conversion in other contexts, e.g.,
> converting both a and b to bool in an expression like `a == b`.
>
> Bug: None
> Change-Id: I79ef35b1ea831e6011ae472900375ae8a3e617ab
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250664
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#35927}

TBR=mbonadei@webrtc.org,nisse@webrtc.org,tommi@webrtc.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I392cd0c7bd96c90e0db20831864418adb7d58bc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251080
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35929}
This commit is contained in:
Mirko Bonadei
2022-02-07 09:54:08 +00:00
committed by WebRTC LUCI CQ
parent e79f85c10e
commit c1fd46f879
5 changed files with 5 additions and 7 deletions

View File

@ -36,9 +36,7 @@ class RtcEventLogParseStatus {
}
bool ok() const { return error_.empty(); }
ABSL_DEPRECATED("Use ok() instead") explicit operator bool() const {
return ok();
}
ABSL_DEPRECATED("Use ok() instead") operator bool() const { return ok(); }
std::string message() const { return error_; }

View File

@ -225,7 +225,7 @@ std::vector<ProbeClusterConfig> ProbeController::OnMaxTotalAllocatedBitrate(
probes.push_back(second_probe_rate.bps());
}
return InitiateProbing(at_time_ms, probes,
config_.allocation_allow_further_probing.Get());
config_.allocation_allow_further_probing);
}
max_total_allocated_bitrate_ = max_total_allocated_bitrate;
return std::vector<ProbeClusterConfig>();

View File

@ -149,7 +149,7 @@ class ScopedBuf {
}
}
explicit operator bool() { return map_ != MAP_FAILED; }
operator bool() { return map_ != MAP_FAILED; }
void initialize(uint8_t* map, int map_size, int fd) {
map_ = map;

View File

@ -220,7 +220,7 @@ class FieldTrialFlag : public FieldTrialParameterInterface {
explicit FieldTrialFlag(std::string key);
FieldTrialFlag(std::string key, bool default_value);
bool Get() const;
explicit operator bool() const;
operator bool() const;
protected:
bool Parse(absl::optional<std::string> str_value) override;

View File

@ -16,7 +16,7 @@ namespace {
struct TestType {
TestType() : has_value(true) {}
TestType(bool b) : has_value(b) {}
explicit operator bool() { return has_value; }
operator bool() { return has_value; }
bool has_value;
int retain_count = 0;
};