From c2302e8e2eb6d5b51c273bdd4986c7b61867da32 Mon Sep 17 00:00:00 2001 From: Michael Morrison Date: Wed, 26 Aug 2020 18:10:35 -0600 Subject: [PATCH] Fix compile error when rtc_enable_protobuf is false When configuring without protobuf this test fails to compile with the error: perf_test_histogram_writer_no_protobuf.cc:20:1: error: non-void function does not return a value Bug: None Change-Id: I8e2676ee4b5284eac08e648fc43bdfc585fc5d64 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/182740 Reviewed-by: Taylor Reviewed-by: Niels Moller Commit-Queue: Taylor Cr-Commit-Position: refs/heads/master@{#32021} --- test/testsupport/perf_test_histogram_writer_no_protobuf.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/test/testsupport/perf_test_histogram_writer_no_protobuf.cc b/test/testsupport/perf_test_histogram_writer_no_protobuf.cc index 17685ccb0d..14deb37c66 100644 --- a/test/testsupport/perf_test_histogram_writer_no_protobuf.cc +++ b/test/testsupport/perf_test_histogram_writer_no_protobuf.cc @@ -16,6 +16,7 @@ namespace test { PerfTestResultWriter* CreateHistogramWriter() { RTC_NOTREACHED() << "Cannot run perf tests with rtc_enable_protobuf = false. " "Perf write results as protobufs."; + return nullptr; } } // namespace test