zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Remove stopped transceivers at both local and remote SetDescription"

Browse Source 
This reverts commit 6f4de80ddddcc05beaced31146ffb753258bc7be.

Reason for revert: Causes breakage in WebRTC roll (WPT tests)

Original change's description:
> Remove stopped transceivers at both local and remote SetDescription
> 
> This should ensure that the correct number of senders and receivers
> are shown.
> 
> Bug: webtc:11840
> Change-Id: Id57f8f9b1ceb8900abb3f92bcae79e5f0341de15
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/184606
> Commit-Queue: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32158}

TBR=hbos@webrtc.org,hta@webrtc.org

Change-Id: Ib91d59f506087dd96c5678262bac7c1580736dcf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webtc:11840
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185053
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32166}
This commit is contained in:
Harald Alvestrand
2020-09-22 21:06:05 +00:00
committed by Commit Bot
parent 10f6eadd48
commit c253cb84aa
5 changed files with 51 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pc/peer_connection_interface_unittest.cc
View File

@ -2671,8 +2671,8 @@ TEST_P(PeerConnectionInterfaceTest, CloseAndTestStreamsAndStates) {
EXPECT_EQ(1u, pc_->local_streams()->count());
EXPECT_EQ(1u, pc_->remote_streams()->count());
} else {
// Verify that the RtpTransceivers are still returned.
EXPECT_EQ(2u, pc_->GetTransceivers().size());
// Verify that the RtpTransceivers are no longer returned.
EXPECT_EQ(0u, pc_->GetTransceivers().size());
}
auto audio_receiver = GetFirstReceiverOfType(cricket::MEDIA_TYPE_AUDIO);