zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable opus tests to allow upgrade to opus 1.3

Browse Source 
The upgrade to opus 1.3 is easier to carry out while the opus
bitexactness tests are temporarily disabled.

Bug: webrtc:11325
Change-Id: I96eecdbc93a01da88b92ae7f6473034c9795f3a0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167726
Commit-Queue: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30425}
This commit is contained in:
Ivo Creusen
2020-01-30 15:01:45 +01:00
committed by Commit Bot
parent bef818d4d9
commit c31a4ec66a
5 changed files with 22 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/audio_coding/neteq/audio_decoder_unittest.cc
View File

@ -599,7 +599,8 @@ TEST_F(AudioDecoderG722StereoTest, SetTargetBitrate) {
TestSetAndGetTargetBitratesWithFixedCodec(audio_encoder_.get(), 128000);
}
TEST_P(AudioDecoderOpusTest, EncodeDecode) {
// TODO(webrtc:11325) Reenable after Opus has been upgraded to 1.3.
TEST_P(AudioDecoderOpusTest, DISABLED_EncodeDecode) {
constexpr int tolerance = 6176;
const int channel_diff_tolerance = opus_sample_rate_hz_ == 16000 ? 6 : 0;
constexpr double mse = 238630.0;

6
modules/audio_coding/neteq/neteq_unittest.cc
View File

@ -105,7 +105,8 @@ TEST_F(NetEqDecodingTest, MAYBE_TestBitExactness) {
#else
#define MAYBE_TestOpusBitExactness DISABLED_TestOpusBitExactness
#endif
TEST_F(NetEqDecodingTest, MAYBE_TestOpusBitExactness) {
// TODO(webrtc:11325) Reenable after Opus has been upgraded to 1.3.
TEST_F(NetEqDecodingTest, DISABLED_TestOpusBitExactness) {
const std::string input_rtp_file =
webrtc::test::ResourcePath("audio_coding/neteq_opus", "rtp");
@ -134,7 +135,8 @@ TEST_F(NetEqDecodingTest, MAYBE_TestOpusBitExactness) {
#else
#define MAYBE_TestOpusDtxBitExactness DISABLED_TestOpusDtxBitExactness
#endif
TEST_F(NetEqDecodingTest, MAYBE_TestOpusDtxBitExactness) {
// TODO(webrtc:11325) Reenable after Opus has been upgraded to 1.3.
TEST_F(NetEqDecodingTest, DISABLED_TestOpusDtxBitExactness) {
const std::string input_rtp_file =
webrtc::test::ResourcePath("audio_coding/neteq_opus_dtx", "rtp");