zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Deprecate RTPFragmentationHeader argument to AudioPacketizationCallback::SendData

Browse Source 
It appears unused everywhere. It will be deleted in a followup cl.

Bug: webrtc:6471
Change-Id: Ief992db6e52aee3cf1bc77ffd659ffbc072672ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134212
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27787}
This commit is contained in:
Niels Möller
2019-04-25 16:31:18 +02:00
committed by Commit Bot
parent e670fd9795
commit c35b6e675a
17 changed files with 54 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
modules/audio_coding/include/audio_coding_module.h
View File

@ -40,12 +40,27 @@ class AudioPacketizationCallback {
public:
virtual ~AudioPacketizationCallback() {}
virtual int32_t SendData(AudioFrameType frame_type,
uint8_t payload_type,
uint32_t timestamp,
const uint8_t* payload_data,
size_t payload_len_bytes) {
return SendData(frame_type, payload_type, timestamp, payload_data,
payload_len_bytes, nullptr);
}
// TODO(bugs.webrtc.org/6471) Deprecated, delete as soon as downstream
// implementations are updated. Then make above method pure virtual, and
// delete forward declaration of RTPFragmentationHeader.
virtual int32_t SendData(AudioFrameType frame_type,
uint8_t payload_type,
uint32_t timestamp,
const uint8_t* payload_data,
size_t payload_len_bytes,
const RTPFragmentationHeader* fragmentation) = 0;
const RTPFragmentationHeader* fragmentation) {
return SendData(frame_type, payload_type, timestamp, payload_data,
payload_len_bytes);
}
};
// Callback class used for reporting VAD decision