zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove flag PaceAtLossBaseBweWhenLoss as it is not used.

Browse Source 
Change-Id: Ie08745e302c1fe582d4ed3b86e96d7a95d021d78
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283361
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Diep Bui <diepbp@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38632}
This commit is contained in:
Diep Bui
2022-11-14 11:37:58 +00:00
committed by WebRTC LUCI CQ
parent 1b8f2d59c4
commit c40cf325b7
2 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
modules/congestion_controller/goog_cc/goog_cc_network_control.cc
View File

@ -85,8 +85,6 @@ GoogCcNetworkController::GoogCcNetworkController(NetworkControllerConfig config,
pace_at_max_of_bwe_and_lower_link_capacity_(
IsEnabled(key_value_config_,
"WebRTC-Bwe-PaceAtMaxOfBweAndLowerLinkCapacity")),
pace_at_loss_based_bwe_when_loss_(
IsEnabled(key_value_config_, "WebRTC-Bwe-PaceAtLossBaseBweWhenLoss")),
probe_controller_(
new ProbeController(key_value_config_, config.event_log)),
congestion_window_pushback_controller_(
@ -688,10 +686,7 @@ PacerConfig GoogCcNetworkController::GetPacingRates(Timestamp at_time) const {
// Pacing rate is based on target rate before congestion window pushback,
// because we don't want to build queues in the pacer when pushback occurs.
DataRate pacing_rate = DataRate::Zero();
if ((pace_at_max_of_bwe_and_lower_link_capacity_ ||
(pace_at_loss_based_bwe_when_loss_ &&
last_loss_based_target_rate_ >= delay_based_bwe_->last_estimate())) &&
estimate_) {
if (pace_at_max_of_bwe_and_lower_link_capacity_ && estimate_) {
pacing_rate =
std::max({min_total_allocated_bitrate_, estimate_->link_capacity_lower,
last_loss_based_target_rate_}) *

1
modules/congestion_controller/goog_cc/goog_cc_network_control.h
View File

@ -95,7 +95,6 @@ class GoogCcNetworkController : public NetworkControllerInterface {
const RateControlSettings rate_control_settings_;
const bool loss_based_stable_rate_;
const bool pace_at_max_of_bwe_and_lower_link_capacity_;
const bool pace_at_loss_based_bwe_when_loss_;
const std::unique_ptr<ProbeController> probe_controller_;
const std::unique_ptr<CongestionWindowPushbackController>