From c41478f7ebc20ea4f687e1c5268fea04e327e072 Mon Sep 17 00:00:00 2001 From: "kjellander@webrtc.org" Date: Fri, 19 Apr 2013 11:50:42 +0000 Subject: [PATCH] Ensure build_demo.py run subprocesses with bash shell. It turns out the default shell becomes /bin/sh on Lucid. By specifying the shell for subprocess.check_call we ensure bash is used. Thanks to yujie.mao@intel.com for pointing this out. BUG=1659 TEST=Successful build with build_demo.py both on Ubuntu Lucid and Precise. TBR=leozwang Review URL: https://webrtc-codereview.appspot.com/1343004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@3875 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/video_engine/test/android/build_demo.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/webrtc/video_engine/test/android/build_demo.py b/webrtc/video_engine/test/android/build_demo.py index 92758aba4c..eb7552729d 100755 --- a/webrtc/video_engine/test/android/build_demo.py +++ b/webrtc/video_engine/test/android/build_demo.py @@ -54,7 +54,8 @@ def main(): cmd = RunInAndroidEnv('ndk-build') print cmd try: - subprocess.check_call(cmd, cwd=_CURRENT_DIR, shell=True) + subprocess.check_call(cmd, cwd=_CURRENT_DIR, executable='/bin/bash', + shell=True) except subprocess.CalledProcessError as e: print 'NDK build failed: %s' % e print '@@@STEP_FAILURE@@@' @@ -64,7 +65,8 @@ def main(): cmd = RunInAndroidEnv('ant %s' % options.target.lower()) print cmd try: - subprocess.check_call(cmd, cwd=_CURRENT_DIR, shell=True) + subprocess.check_call(cmd, cwd=_CURRENT_DIR, executable='/bin/bash', + shell=True) except subprocess.CalledProcessError as e: print 'Ant build failed: %s' % e print '@@@STEP_FAILURE@@@'